Avoid test race condition. #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was seeing a race running e2e tests where immediately after applying a policy we immediately expect it to be enforced, but it takes time to compile and distribute the policy configmap. As I was copying this other places, I noticed that the sleeps already existed, so I added my more detailed comment to the instances I found. Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 58.94% 58.94%
=======================================
Files 21 21
Lines 2097 2097
=======================================
Hits 1236 1236
Misses 799 799
Partials 62 62 Continue to review full report at Codecov.
|
vaikas
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was seeing a race running e2e tests where immediately after applying a policy we immediately expect it to be enforced, but it takes time to compile and distribute the policy configmap.
As I was copying this other places, I noticed that the sleeps already existed, so I added my more detailed comment to the instances I found.
cc @vaikas @hectorj2f
Documentation