Merged
Conversation
segiddins
force-pushed
the
segiddins/wip-begin-implementing-dsse-in-toto-support
branch
2 times, most recently
from
4d722ee to
9a1479e
Compare
segiddins
force-pushed
the
segiddins/wip-begin-implementing-dsse-in-toto-support
branch
from
9a1479e to
256e7c6
Compare
segiddins
changed the title
segiddins
commented
May 7, 2024
| "content" => { | ||
| "envelope" => { | ||
| "payloadType" => dsse_envelope.payloadType, | ||
| "payload" => [[dsse_envelope.payload].pack("m0")].pack("m0"), |
Member
Author
There was a problem hiding this comment.
are these double base64 encodings really correct?
| "content" => [signature].pack("m0"), | ||
| "publicKey" => { | ||
| "content" => [certificate.to_pem].pack("m0") | ||
| if signature |
Member
Author
There was a problem hiding this comment.
this will be a lot clearer once I refactor the verifier to work directly on the sigstore protocol objects (a dev.sigstore.verification.v1.Input)
| task conformance: %w[conformance:setup] do | ||
| sh({ "GHA_SIGSTORE_CONFORMANCE_XFAIL" => | ||
| "test_verify_dsse_bundle_with_trust_root" }, | ||
| "test_verify_rejects_bad_tsa_timestamp" }, |
Member
Author
There was a problem hiding this comment.
I couldn't get openssl to use the correct timestamp for TSA validation. That code is essentially a no-op now, but at least the bones of DSSE bundle validation works!
segiddins
deleted the
segiddins/wip-begin-implementing-dsse-in-toto-support
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.