New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Korean Hangul Syllables on han3_ji7_tsoo1_kian3 #79

Merged
merged 7 commits into from Apr 23, 2018

Conversation

Projects
None yet
5 participants
@studioego
Copy link
Contributor

studioego commented Feb 16, 2018

That project's font files not supported Korean Hangul Syllable Characters, for example 가(U+AC00)-힣(D7A3).

I add two Korean Hangul Fonts, "Nanum Gothic" and "Nanum Myeongjo" on Project.
prefix "Nanum" is brand name.
"Gothic" is "고딕체/고딕體", reads "godikche" in Korean. I think The Chinese font 楷體 is equivalent to the Korean font Gothic 고딕체.
"Myeongjo" is "명조체/明朝體", reads " myeongjoche" in Korean. I think The Chinese font 宋體 is equivalent to the Korean font Myeongjo 명조체/明朝體.
Nanum-series Korean Font Official Link1: http://hangeul.naver.com/download.nhn
Nanum-series Korean Font Official Link2: http://hangeul.naver.com/2017/nanum

BTW, These Font's License is SIL Open Font License.
License Information Link: http://help.naver.com/ops/step2/faq.nhn?faqId=15879

Also, These fonts are default font on Ubuntu Korean Language distribution.

example) ⿴囗도
Ref: https://twitter.com/ursaqita/status/897102713007120384
⿴囗도
"⿴囗도". This word origin from Chinese Character "圖".
"圖" reads "do" in Korean, write "도" in Korean Hangul.
I think that "⿴囗도"'s notation seems to be denoted to emphasizes Korean Sound "do"(도).

studioego added some commits Jan 28, 2018

Merge pull request #1 from sih4sing5hong5/master
merge from head repository
Support Korean Hangul Syllables on han3_ji7_tsoo1_kian3
That project's font files not supported Korean Hangul Syllable Characters, for example 가(U+AC00)-힣(D7A3)
I add two Korean Hangul Fonts, "Nanum Gothic" and "Nanum Myeongjo" on Project.
prefix "Nanum" is brand name.
"Gothic" is "고딕체/고딕體", reads "godikche" in Korean. I think The Chinese font 楷體 is equivalent to the Korean font Gothic 고딕체.
"Myeongjo" is "명조체/明朝體", reads " myeongjoche" in Korean. I think The Chinese font 宋體 is equivalent to the Korean font Myeongjo 명조체/明朝體.
Link: http://hangeul.naver.com/2017/nanum

example) ⿴囗도
Ref: https://twitter.com/ursaqita/status/897102713007120384
⿴囗도
 "⿴囗도". This word origin from Chinese Character "圖".
"圖" reads "do" in Korean, write "도" in Korean Hangul.
I think that "⿴囗도"'s notation seems to be denoted to emphasizes Korean Sound "do"(도).
@hfhchan

This comment has been minimized.

Copy link

hfhchan commented Feb 17, 2018

If Gothic is sans-serif, then the Chinese name is 黑體

@Artoria2e5

This comment has been minimized.

Copy link
Collaborator

Artoria2e5 commented Feb 17, 2018

Yep, the "proper" Sans-serif/黑 for Korean should look like https://typekit.com/fonts/source-han-sans-korean. 나눔고딕 is the sans-serif on your page.

I am actually curious about Hangul Ming (Serif) / Kai (regular script) though: in most Korean serif fonts, Hangul glyphs come with some pretty script-like stroke variations, making them look somehow like Kai. (e.g. 나눔명조 and https://typekit.com/fonts/source-han-serif-korean.) Is there a way to reliably tell a 楷書 from a 明朝體 only given the Hangul part? Or are they just supposed to be the same?


(See #78 for why the test failed.)

@studioego

This comment has been minimized.

Copy link
Contributor Author

studioego commented Feb 21, 2018

I think I misunderstood Korean fonts.

@hfhchan If Gothic is sans-serif, then the Chinese name is 黑體

Yes. Korean font 고딕체[Gothic, Godik-che] is sans-serif, then the Chinese name is 黑體

@Artoria2e5 Is there a way to reliably tell a 楷書 from a 明朝體 only given the Hangul part?

No. Another is 궁서체[Gungseo-Che or gungsuh-che,宮書體].
The 궁서체[Gungseo-Che or gungsuh-che,宮書體] is the abbreviation of the 궁중 서체[宮中書體/gungjung-seoche].
It looks like Korean 楷體 or 해서체[HaeSeo-Che,楷書體].
The Font style popular among girls in the Korean palace since 500 years ago.

The '해서체/楷書體Haeseo-che ' font is similar to the '궁서체[Gungseo-Che or gungsuh-che,宮書體]' font.
In Korea, Korean mixed script[국한문혼용문(國漢文混用文), a form of writing that uses both Hangul(Hangeul, 한글) and Hanja/한자/漢字, Ideograph] mostly use both 해서체[HaeSeo-Che,楷書體] font on Hanja(漢字) and 궁서체[Gungseo-Che or gungsuh-che,宮書體] font on Hangul(한글).

This is 궁서체[Gungseo-Che or gungsuh-che,宮書體]'s description on Chinese Wikipedia. https://zh.wikipedia.org/wiki/宮書體

It's Chinese font examples on LibreOffice.
https://www.facebook.com/groups/libreozht.users/permalink/1634397096583409/

I'll check All Open Source font in Korean. @hfhchan @Artoria2e5

After doing research on Korean Open Source fonts, I'll fix the code & font files.

Thank you for your advice.

This is Windows Korean Font's examples.
바탕체[Batang-Che,바탕體] - Serif, [In the mid-1990s, Korean Ministry of Culture(문화부/文化部, Munhwa-bu) specified this term, replacing Myeongjo(명조체/明朝體,myeongjo-che]
돋음체[Dotum-Che,돋음體] - Sans-serif, It's Gothic's Korean name. [In the mid-1990s, Korean Ministry of Culture(문화부/文化部, Munhwa-bu) specified this term, replacing Gothic(고딕체/고딕體,godik-che]
굴림체[Gulim-Che,굴림體] - Sans-serif
궁서체[Gungseo-Che or gungsuh-che,宮書體) - Maybe It looks like Korean 楷體 or 해서체[HaeSeo-Che,楷書體].

MS Unicode Fonts 서체(書體)Windows XP/Vista

@Artoria2e5

This comment has been minimized.

Copy link
Collaborator

Artoria2e5 commented Feb 21, 2018

Ah, just take notice that the tests are broken because the Java version is now too low for gradle to downlad things. I think the fonts you are looking at are OK, as they are SIL OFL.

We are trying to figure out a way to not store the fonts in git, but that's not done yet, so feel free to just put the fonts alongside the source in this pull request.

Also on our todo list is a sans-serif font for Chinese. All you need to focus on is Batang and HaeSeo for now I guess.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 21, 2018

Codecov Report

Merging #79 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #79      +/-   ##
===========================================
- Coverage      4.54%   4.54%   -0.01%     
  Complexity       69      69              
===========================================
  Files           130     130              
  Lines          3346    3348       +2     
  Branches        255     255              
===========================================
  Hits            152     152              
- Misses         3186    3188       +2     
  Partials          8       8
Impacted Files Coverage Δ Complexity Δ
...java/cc/char_indexingtool/FontCorrespondTable.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0c2ee...bf7bfa5. Read the comment docs.

@Artoria2e5
Copy link
Collaborator

Artoria2e5 left a comment

Also, put the font in git-lfs

@@ -22,6 +22,7 @@
"/font/CNS11643-101_11_28/TW-Kai-98_1.ttf",
"/font/CNS11643-101_11_28/TW-Kai-Ext-B-98_1.ttf",
"/font/CNS11643-101_11_28/TW-Kai-Plus-98_1.ttf",
"/font/NanumFont/NanumGothic.ttf",

This comment has been minimized.

@Artoria2e5

Artoria2e5 Feb 21, 2018

Collaborator

We should use NanumMyeongjo for both for now. NanumMyeongjo's Hangul looks more "Kai" than the Gothic.

This comment has been minimized.

@Artoria2e5

Artoria2e5 Feb 21, 2018

Collaborator

The Gothic part will be used after we figure out 黑體支援.

This comment has been minimized.

@studioego

studioego Feb 24, 2018

Author Contributor

Now, I add UnGungSeo.tff file.
궁서체(Gungseo-Che or gungsuh-che,宮書體), is equivalent to the Chinese font 楷體.
Changed NanumGothic.tff as 黑體 to UnGungSeo.tff as 楷體.
It's GPLv2 License fonts.

add UnGungSeo.tff. It is script font for Korean Hangul.
"GungSeo" is "궁서체/宮書體", reads "gungseoche" in Korea.
궁서체(Gungseo-Che or gungsuh-che,宮書體), is equivalent to the Chinese font 楷體.
Changed NanumGothic.tff as 黑體 to UnGungSeo.tff as 楷體.

UnGungSeo font is included in UnFont package(Un series Korean TrueType fonts).
UnGungSeo(은궁서)– included in most Linux distributions. Initially made by Un Koanghui(은광희) as a set of type 1 typefaces to use with Korean LaTeX. Later they were converted to opentype typefaces by Park Won-gyu (박원규). UnBatang also has a version with opentype GSUB/GPOS tables to support archaic Hangul with Hangul Conjoining Jamos.

It's GPLv2 License fonts.

unfont Site
https://kldp.net/unfonts/

CTAN: Package unfonts-core
https://ctan.org/pkg/unfonts-core
@studioego
Copy link
Contributor Author

studioego left a comment

"GungSeo" is "궁서체/宮書體", reads "gungseoche" in Korea.
궁서체(Gungseo-Che or gungsuh-che,宮書體), is equivalent to the Chinese font 楷體.
Changed NanumGothic.tff as 黑體 to UnGungSeo.tff as 楷體.

UnGungSeo font is included in UnFont package(Un series Korean TrueType fonts).
UnGungSeo(은궁서)– included in most Linux distributions. Initially made by Un Koanghui(은광희) as a set of type 1 typefaces to use with Korean LaTeX. Later they were converted to opentype typefaces by Park Won-gyu (박원규). UnBatang also has a version with opentype GSUB/GPOS tables to support archaic Hangul with Hangul Conjoining Jamos.

It's GPLv2 License fonts.

unfont Site
https://kldp.net/unfonts/

CTAN: Package unfonts-core
https://ctan.org/pkg/unfonts-core

@@ -22,6 +22,7 @@
"/font/CNS11643-101_11_28/TW-Kai-98_1.ttf",
"/font/CNS11643-101_11_28/TW-Kai-Ext-B-98_1.ttf",
"/font/CNS11643-101_11_28/TW-Kai-Plus-98_1.ttf",
"/font/NanumFont/NanumGothic.ttf",

This comment has been minimized.

@studioego

studioego Feb 24, 2018

Author Contributor

Now, I add UnGungSeo.tff file.
궁서체(Gungseo-Che or gungsuh-che,宮書體), is equivalent to the Chinese font 楷體.
Changed NanumGothic.tff as 黑體 to UnGungSeo.tff as 楷體.
It's GPLv2 License fonts.

studioego added some commits Apr 22, 2018

add Korean Alphabet(Hangul) Font link
add Korean Alphabet(Hangul) Font link
supported both 楷體(해서체/楷書體,UnGungseo.ttf) and 宋體(명조체/明朝體,
NanumMyeongjo.ttf) fonts
@studioego

This comment has been minimized.

Copy link
Contributor Author

studioego commented Apr 22, 2018

changed java file

@sih4sing5hong5

This comment has been minimized.

Copy link
Owner

sih4sing5hong5 commented Apr 22, 2018

@studioego Is the PR finished or WIP ?
If completed, we will merge this.

@studioego

This comment has been minimized.

Copy link
Contributor Author

studioego commented Apr 22, 2018

Yes, Completed it. Please, merge it

@sih4sing5hong5 sih4sing5hong5 merged commit 2842776 into sih4sing5hong5:master Apr 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment