Change variable $TASK_DEFINITION to $taskDefinition (--task-definition-file option not working)

[inokappa]

Hi

When we use --task-definition-file, the content of the file specified by the --task-definition-file option is not used,
because of the following situation.

    if [ $TASK_DEFINITION_FILE == false ]; then
        taskDefinition="$TASK_DEFINITION"
    else
        taskDefinition="$(cat $TASK_DEFINITION_FILE)"
    fi

    # Get a JSON representation of the current task definition
    # + Update definition to use new image name
    # + Filter the def
    if [[ "x$TAGONLY" == "x" ]]; then

      DEF=$( echo "$TASK_DEFINITION" \
            | sed -e 's~"image":.*'"${imageWithoutTag}"'.*,~"image": "'"${useImage}"'",~g' \
            | jq '.taskDefinition' )

Please confirm.

Yohei

[jfranzoi]

Hi, I can confirm as well.

I was just trying to get --task-definition-file working, patched with the same fix, and going to open a PR.. but finally found there was already this one 👍.

Only reminder for others, don't forget that task definition JSON object starts with:
{ "taskDefinition": { ... } }! (I spent almost one hour digging on why it was loading an empty definition..)

[fillup]

Thank you @inokappa!