fix DB restore error #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restore.sh used DB_USER to create an empty DB if needed. This failed but AWS RDS ended up doing the right thing anyway. The script now uses DB_ROOTUSER and the default postgres DB when creating the target DB. The application was upgraded to use Alpine 3.15 and the PostgreSQL 12 client to be compatible with previous backup files.
Update the documentation. Upgrade the DB server to Alpine 3.15 and PostgreSQL 11.15. Provide an updated test database.
briskt
approved these changes
Mar 16, 2022
|
|
||
| start=$(date +%s) | ||
| psql --host=${DB_HOST} --username=${DB_USER} --dbname=${DB_NAME} ${DB_OPTIONS} < /tmp/${DB_NAME}.sql || STATUS=$? | ||
| psql --host=${DB_HOST} --username=${DB_ROOTUSER} --dbname=postgres ${DB_OPTIONS} < /tmp/${DB_NAME}.sql || STATUS=$? |
Contributor
There was a problem hiding this comment.
README still refers to DB_NAME. Is that OK?
Contributor
Author
There was a problem hiding this comment.
Yes. DB_NAME is the name of the DB we want to restore which will be in the DB backup file (${DB_NAME}.sql). The --dbname=postgres is required since the DB backup file DROPs $DB_NAME before creating it and you can't drop a DB that you are connected to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.