From bca007fa0dac2a2e2889ac6194de4dfb3f096461 Mon Sep 17 00:00:00 2001 From: Caleb Maclennan Date: Tue, 30 Aug 2022 13:25:23 +0300 Subject: [PATCH] Revert "chore(build): Avoid mktemp during build, breaks opensuse packaging (#1542)" This reverts commit c6ad2f60815b91752edd73db20ba4c92ba247eb3. The issue on openSUSE turned out to be something else, and the mktemp solution is just slightly more robust that the per-version filename thing. It is less likely to reuse parts of an old test or hand generated file in the event of weird filesystem ACLs. --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index d9911bf84..d13daef89 100644 --- a/Makefile.am +++ b/Makefile.am @@ -140,7 +140,7 @@ check: selfcheck .PHONY: selfcheck selfcheck: | $(_BUILT_SUBDIRS) - output=selfcheck-$(VERSION).pdf + output=$$(mktemp -t selfcheck-XXXXXX.pdf) trap 'rm -f $$output' EXIT HUP TERM echo "foo" | ./$(SILE) -o $$output - $(PDFINFO) $$output | $(GREP) "SILE v$(VERSION)"