Support ICU 76.1. Build fails on macOS. Runtime missing symbols on Linux

[cho-m]

Seen while updating to new ICU 76.1 release in Homebrew Homebrew/homebrew-core#193114

Might be related to unicode-org/icu@199bc82. May need a direct icu-i18n in

sile/configure.ac

Lines 149 to 150 in 3b62dab

	PKG_CHECK_MODULES(ICU, icu-uc icu-io, [
	with_icu=yes

On macOS, build fails with:

libtool: link: clang  -o .libs/justenoughicu.so -bundle  .libs/justenoughicu_la-justenoughicu.o .libs/justenoughicu_la-compat-5.3.o   -L/opt/homebrew/opt/luajit/lib -L/opt/homebrew/Cellar/icu4c@76/76.1/lib -licuuc -licuio -lluajit-5.1  -g -O2  
libtool: link: ar cr .libs/svg.a  svg_la-svg.o svg_la-compat-5.3.o
Undefined symbols for architecture arm64:
  "_ucol_close_76", referenced from:
      _je_icu_collation_destroy in justenoughicu_la-justenoughicu.o

On Linux, sile builds but then fails at runtime:

error loading module 'justenoughicu' from file '/home/linuxbrew/.linuxbrew/Cellar/sile/0.15.5_2/lib/sile/justenoughicu.so':
	/home/linuxbrew/.linuxbrew/Cellar/sile/0.15.5_2/lib/sile/justenoughicu.so: undefined symbol: ucol_strcollUTF8_76
stack traceback:
	[C]: in ?
	[C]: in ?
	[C]: in function 'require'
	...llar/sile/0.15.5_2/share/sile/core/utilities/numbers.lua:4: in main chunk
	[C]: in function 'require'
	.../Cellar/sile/0.15.5_2/share/sile/core/utilities/init.lua:818: in main chunk
	[C]: in function 'require'
	....linuxbrew/Cellar/sile/0.15.5_2/share/sile/core/sile.lua:64: in main chunk
	[C]: in function 'require'

I believe these symbols are part of libicui18n.{dylib,so}.

[alerque]

Thanks for the report, I'll look into what we can do.

I also see Harfbuzz is having some trouble with this ICU update, so that needs to get worked out before we'll be able to build too.

[cho-m]

I also see Harfbuzz is having some trouble with this ICU update, so that needs to get worked out before we'll be able to build too.

Personally haven't seen an issue with Harfbuzz but may be different build toolchains. On Linux, Homebrew builds with GCC 11 on Ubuntu 22.04.

[alerque]

I just gave the tree a quick shake over on this branch (not using the last commit of course) using Nix's icu76 package which seems to be 76.1rc right now. Both the default gcc based Flake (nix run . -- --version) and the clang variant (nix run .#sile-clang -- --version) seemed to build fine. I'm not 100% sure I'm debugging it right though.

In the mean time Arch Linux is still stick on ICU 75, so this is not very easy for me to dig into.

May need a direct icu-i18n ...

If you can apply this patch or equivalent and confirm this is the only change needed I'd be happy to get it applied early and out in a release before other distros get hung on this.

[cho-m]

If you can apply this patch or equivalent and confirm this is the only change needed I'd be happy to get it applied early and out in a release before other distros get hung on this.

I am using something similar in Homebrew PR¹ (specifically adjusting configure to avoid regeneration). Based on ongoing CI run, build is successful and no issues with basic test we run.

Behavior should be backwards compatible.

Footnotes

1. https://github.com/Homebrew/homebrew-core/pull/193114/files#diff-3eb1279f99561316a5b5d8760ed698b7e59328c530212cc887e177dda19289e2R148 ↩