Clean up ICU shim

[alerque]

Long term this shim might go away, but first I have to figure out what it is doing and make sure it is doing it right so we even have something to compare against.

Closes #359

[srl295]

3-byte UTF-8 excludes non-BMP chars! (> U+FFFF )

[alerque]

Thanks for the obviously correct byte count @srl295.

What isn't obvious to me is whether the original issue your reported has been properly and completely fixed. The cheese has just moved too much for my lack of C knowledge. It does look like there is one less malloc() in that look and the writes to the Lua side make more sense to me, but still...

The original you reported the issue on would have been from just before the v0.9.4 release:
https://github.com/sile-typesetter/sile/blob/v0.9.4/src/justenoughicu.c#L74

If it is done it would be nice to know and get the issue closed with this final tweak.

[srl295]

Thanks for the obviously correct byte count @srl295.

+1

What isn't obvious to me is whether the original issue your reported has been properly and completely fixed. The cheese has just moved too much for my lack of C knowledge. It does look like there is one less malloc() in that look and the writes to the Lua side make more sense to me, but still...

I replied on that issue that yes it does seem fixed.

The original you reported the issue on would have been from just before the v0.9.4 release: https://github.com/sile-typesetter/sile/blob/v0.9.4/src/justenoughicu.c#L74

If it is done it would be nice to know and get the issue closed with this final tweak.