Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Fix version detection in sparse git checkouts #803

Merged
merged 1 commit into from Jan 29, 2020

Conversation

@alerque
Copy link
Member

alerque commented Jan 29, 2020

Building from a git clone worked before, but some distro packages (Arch Linux sile-git for example) use a sparse checkout without all the branches available. This throws git warnings for the branch names that don't have corresponding repository data, but they can be ignored as long as the current HEAD gives us something meaningful.

@alerque alerque added the packaging label Jan 29, 2020
@alerque alerque added this to the v0.10.2 milestone Jan 29, 2020
@alerque alerque merged commit e46091f into sile-typesetter:master Jan 29, 2020
5 of 6 checks passed
5 of 6 checks passed
commitlint
Details
luacheck
Details
Docker Build Task Summary
Details
Travis CI - Pull Request Build Passed
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
sile-typesetter.sile Build #20200129.1 succeeded
Details
@alerque alerque deleted the alerque:robust-version-detection branch Jan 29, 2020
simoncozens added a commit that referenced this pull request Feb 3, 2020
Previous fix got us into the case statement but didn't provide any useful information once we got there. This provides *something*, at least.
alerque pushed a commit that referenced this pull request Feb 5, 2020
Previous fix got us into the case statement but didn't provide any useful information once we got there. This provides *something*, at least.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.