This repository has been archived by the owner on Jul 4, 2018. It is now read-only.
Fixed Session Service Provider registry #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragboyjr
force-pushed
the
session-provider-params
branch
from
f64b71a
to
b81b099
Compare
|
|
||
| /** | ||
| * Test that you can properly configure the Session class. | ||
| */ |
There was a problem hiding this comment.
I don't think we need this comment.
ragboyjr
force-pushed
the
session-provider-params
branch
from
b81b099
to
c7b1c76
Compare
|
@fabpot. Those are updated. out of curiosity with doing conditionals on one line, how would you format a bunch of conditions so that the line isn't so long. $long_var_name == 1 || $long_var_name_b == 1 || ($long_var_name_2 == 2 || $long_var_name3 == 2) && $one_more_long_var_name ==5 |
|
Everyone has a large screen nowadays, so there is no need to cut lines at 80 chars. |
| $session = $app['session']; | ||
|
|
||
| $valid = $session->getBag('flashes') === $flash && $session->getBag('attributes') === $attrs; | ||
| $this->assertTrue($valid); |
There was a problem hiding this comment.
I'd have be more precise like:
$this->assertSame($flash, $session->getBag('flashes');
$this->assertSame($attrs, $session->getBag('attributes');There was a problem hiding this comment.
No problem, I was just trying to keep the whole 1 assertion per test.
The service provider was registering the wrong parameters to the session listener instead of the actual session class Signed-off-by: RJ Garcia <rj@bighead.net>
ragboyjr
force-pushed
the
session-provider-params
branch
from
c7b1c76
to
cecdb85
Compare
|
Thank you @ragboyjr. |
fabpot
added a commit
that referenced
this pull request
May 4, 2016
This PR was merged into the 2.0.x-dev branch. Discussion ---------- Fixed Session Service Provider registry The service provider was registering the wrong parameters to the session listener instead of the actual session class This fixes #1342 Signed-off-by: RJ Garcia <rj@bighead.net> Commits ------- cecdb85 Fixed Session Service Provider registry
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service provider was registering the wrong parameters
to the session listener instead of the actual session class
This fixes #1342
Signed-off-by: RJ Garcia rj@bighead.net