New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example view available in formulars too #141

Merged
merged 8 commits into from Sep 7, 2017

Conversation

Projects
None yet
2 participants
@JorgeMartinezPizarro
Contributor

JorgeMartinezPizarro commented Sep 5, 2017

No description provided.

@JorgeMartinezPizarro JorgeMartinezPizarro requested a review from leipert Sep 5, 2017

@JorgeMartinezPizarro JorgeMartinezPizarro changed the title from example view available in formulars too to WIP: example view available in formulars too Sep 5, 2017

@JorgeMartinezPizarro JorgeMartinezPizarro changed the title from WIP: example view available in formulars too to example view available in formulars too Sep 5, 2017

@haschek

This comment has been minimized.

Show comment
Hide comment
@haschek

haschek Sep 7, 2017

Contributor

@JorgeMartinezPizarro It's currently not possible to merge it because of Javascript errors, we need to fix that first.

Contributor

haschek commented Sep 7, 2017

@JorgeMartinezPizarro It's currently not possible to merge it because of Javascript errors, we need to fix that first.

@JorgeMartinezPizarro

This comment has been minimized.

Show comment
Hide comment
@JorgeMartinezPizarro

JorgeMartinezPizarro Sep 7, 2017

Contributor

Fixed and added rule validation before showing exampleView in formulars within the last 2 commits.

Contributor

JorgeMartinezPizarro commented Sep 7, 2017

Fixed and added rule validation before showing exampleView in formulars within the last 2 commits.

@JorgeMartinezPizarro JorgeMartinezPizarro requested a review from haschek Sep 7, 2017

@haschek haschek merged commit f97544f into develop Sep 7, 2017

@haschek haschek deleted the feature/newPeakApi branch Sep 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment