fix(tests): clean NUnit 3->4 conversion from release/9.3 baseline

Re-checkout all 261 test files from origin/release/9.3 and run
scripts/tests/convert_nunit.py with corrected comparison logic.

This fixes swapped argument order in Greater/Less assertions that
were introduced during the SDK migration rebase (43d1fd5).

The previous conversion incorrectly produced:
  Assert.That(0, Is.GreaterThan(value))  // WRONG - always false

Now correctly produces:
  Assert.That(value, Is.GreaterThan(0))  // CORRECT

Also restores 3 test files that were unintentionally deleted during
the SDK migration:
- Lib/src/ScrChecks/ScrChecksTests/SentenceFinalPunctCapitalizationCheckUnitTest.cs
- Src/Common/ViewsInterfaces/ViewsInterfacesTests/ExtraComInterfacesTests.cs
- Src/FwCoreDlgs/FwCoreDlgsTests/FwWritingSystemSetupDlgTests.cs

Author: johnml1135

Lib/src/ScrChecks/ScrChecksTests/ChapterVerseTests.cs

@@ -4,10 +4,10 @@
 
 using System;
 using System.Collections.Generic;
-using System.Diagnostics;
 using NUnit.Framework;
-using SIL.FieldWorks.Common.FwUtils;
+using System.Diagnostics;
 using SILUBS.ScriptureChecks;
+using SILUBS.SharedScrUtils;
 
 namespace SILUBS.ScriptureChecks
 {
@@ -18,7 +18,9 @@ public class RepeatedWordsCheckUnitTest
 		UnitTestChecksDataSource source = new UnitTestChecksDataSource();
 
 		[SetUp]
-		public void RunBeforeEachTest() { }
+		public void RunBeforeEachTest()
+		{
+		}
 
 		void Test(string[] result, string text)
 		{
@@ -30,20 +32,13 @@ void Test(string[] result, string text, string desiredKey)
 			source.Text = text;
 
 			RepeatedWordsCheck check = new RepeatedWordsCheck(source);
-			List<TextTokenSubstring> tts = check.GetReferences(source.TextTokens(), desiredKey);
+			List<TextTokenSubstring> tts =
+				check.GetReferences(source.TextTokens(), desiredKey);
 
-			Assert.That(
-				tts.Count,
-				Is.EqualTo(result.GetUpperBound(0) + 1),
-				"A different number of results was returned than what was expected."
-			);
+			Assert.That(tts.Count, Is.EqualTo(result.GetUpperBound(0)+1), "A different number of results was returned than what was expected.");
 
 			for (int i = 0; i <= result.GetUpperBound(0); ++i)
-				Assert.That(
-					tts[i].InventoryText,
-					Is.EqualTo(result[i]),
-					"Result number: " + i.ToString()
-				);
+				Assert.That(tts[i].InventoryText, Is.EqualTo(result[i]), "Result number: " + i.ToString());
 		}
 
 		[Test]
@@ -68,21 +63,16 @@ public void DifferentCase()
 		[Ignore("Text needs to be normalized to NFC (or maybe NFD) before check is run.")]
 		public void DifferentNormalization()
 		{
-			Test(
-				new string[] { "B\u00E3r", "B\u00E3r" },
-				"\\p \\v 1 B\u00E3r Ba\u0303r and Ba\u0303r B\u00E3r "
-			);
+			Test(new string[] { "B\u00E3r", "B\u00E3r" },
+				"\\p \\v 1 B\u00E3r Ba\u0303r and Ba\u0303r B\u00E3r ");
 		}
 
 		[Test]
 		[Ignore("Text needs to be normalized to NFC (or maybe NFD) before check is run.")]
 		public void FindingDifferentNormalization()
 		{
-			Test(
-				new string[] { "B\u00E3r", "B\u00E3r" },
-				"\\p \\v 1 B\u00E3r Ba\u0303r and and Ba\u0303r B\u00E3r ",
-				"B\u00E3r"
-			);
+			Test(new string[] { "B\u00E3r", "B\u00E3r" },
+				"\\p \\v 1 B\u00E3r Ba\u0303r and and Ba\u0303r B\u00E3r ", "B\u00E3r");
 		}
 
 		[Test]

Lib/src/ScrChecks/ScrChecksTests/RepeatedWordsCheckUnitTest.cs

@@ -0,0 +1,127 @@
+// Copyright (c) 2015 SIL International
+// This software is licensed under the LGPL, version 2.1 or later
+// (http://www.gnu.org/licenses/lgpl-2.1.html)
+
+using System;
+using System.Collections.Generic;
+using System.Text;
+using NUnit.Framework;
+using System.Diagnostics;
+using System.IO;
+using SILUBS.SharedScrUtils;
+
+namespace SILUBS.ScriptureChecks
+{
+#if DEBUG
+	[TestFixture]
+	public class SentenceFinalPunctCapitalizationCheckUnitTest
+	{
+		UnitTestChecksDataSource source = new UnitTestChecksDataSource();
+
+		[SetUp]
+		public void RunBeforeEachTest()
+		{
+			source.SetParameterValue("ValidPunctuation", "._ !_ ?_");
+		}
+
+		void Test(string[] result, string text)
+		{
+			source.Text = text;
+
+			SentenceFinalPunctCapitalizationCheck check = new SentenceFinalPunctCapitalizationCheck(source);
+			List<TextTokenSubstring> tts =
+				check.GetReferences(source.TextTokens(), "");
+
+			Assert.That(tts.Count, Is.EqualTo(result.GetUpperBound(0)+1), "A different number of results was returned than what was expected.");
+
+			for (int i = 0; i <= result.GetUpperBound(0); ++i)
+				Assert.That(tts[i].InventoryText, Is.EqualTo(result[i]), "Result number: " + i.ToString());
+		}
+
+		[Test]
+		public void UpperCase()
+		{
+			Test(new string[] { }, @"\p \v 1 Foo. Bar");
+		}
+
+		[Test]
+		public void LowerCase()
+		{
+			Test(new string[] { "." }, @"\p \v 1 Foo. bar");
+		}
+
+		[Test]
+		public void NoCaseNonRoman()
+		{
+			Test(new string[] { }, "\\p \\v 1 Foo. \u0E01");
+		}
+
+		[Test]
+		public void NoCasePUA()
+		{
+			Test(new string[] { }, "\\p \\v 1 Foo. \uEE00");
+		}
+
+		[Test]
+		public void TitleCase()
+		{
+			Test(new string[] { }, "\\p \\v 1 Foo. \u01C5");
+		}
+
+		[Test]
+		public void MultipleUpperCase()
+		{
+			Test(new string[] { }, @"\p \v 1 Foo. Bar! Baz");
+		}
+
+		[Test]
+		public void MultipleLowerCase()
+		{
+			Test(new string[] { ".", "!" }, @"\p \v 1 Foo. bar! baz");
+		}
+
+		[Test]
+		public void MultipleMixedCase()
+		{
+			Test(new string[] { "!" }, @"\p \v 1 Foo. Bar! baz");
+		}
+
+		[Test]
+		public void MultiplePunctUpperCase()
+		{
+			Test(new string[] { }, @"\p \v 1 Foo!? Bar");
+		}
+
+		[Test]
+		public void MultiplePunctLowerCase()
+		{
+			Test(new string[] { "!", "?" }, @"\p \v 1 Foo!? bar");
+		}
+
+		[Test]
+		public void Quotes()
+		{
+			Test(new string[] { "!" }, "\\p \\v 1 \u201CFoo!\u201D bar");
+		}
+
+		[Test]
+		public void Digits()
+		{
+			Test(new string[] { }, @"\p \v 1 Foo 1.2 bar");
+		}
+
+		[Test]
+		public void AbbreviationError()
+		{
+			Test(new string[] { "." }, @"\p \v 1 The E.U. headquarters.");
+		}
+
+		[Test]
+		public void AbbreviationOK()
+		{
+			source.SetParameterValue("Abbreviations", "E.U.");
+			Test(new string[] { }, @"\p \v 1 The E.U. headquarters.");
+		}
+	}
+#endif
+}

Lib/src/ScrChecks/ScrChecksTests/SentenceFinalPunctCapitalizationCheckUnitTest.cs

@@ -586,7 +586,7 @@ public void AllMultiStringPropTest()
 			SilDataAccess.SetMultiStringAlt(hvo, tag, 2, tss);
 
 			var tsms = SilDataAccess.get_MultiStringProp(hvo, tag);
-			Assert.That(2, Is.EqualTo(tsms.StringCount));
+			Assert.That(tsms.StringCount, Is.EqualTo(2));
 		}
 
 		/// <summary>

Src/CacheLight/CacheLightTests/RealDataCacheTests.cs

@@ -178,7 +178,7 @@ public void LabelAbbreviations()
 			//		are abbreviated by being truncated to 4 characters.
 			Assert.That((m_dtree.Controls[0] as Slice).Label, Is.EqualTo("CitationForm"));
 			string abbr1 = StringTable.Table.GetString((m_dtree.Controls[0] as Slice).Label, "LabelAbbreviations");
-			Assert.That("*" + (m_dtree.Controls[0] as Slice).Label + "*", Is.EqualTo(abbr1));	// verify it's not in the table.
+			Assert.That(abbr1, Is.EqualTo("*" + (m_dtree.Controls[0] as Slice).Label + "*"));	// verify it's not in the table.
 			Assert.That((m_dtree.Controls[0] as Slice).Abbreviation, Is.EqualTo("Cita"));		// verify truncation took place.
 			// 2) Test that a label in "LabelAbbreviations" defaults to its string table entry.
 			Assert.That((m_dtree.Controls[1] as Slice).Label, Is.EqualTo("Citation Form"));
@@ -187,7 +187,7 @@ public void LabelAbbreviations()
 			Assert.That((m_dtree.Controls[1] as Slice).Abbreviation, Is.EqualTo(abbr2));		// should be identical
 			// 3) Test that a label with an "abbr" attribute overrides default abbreviation.
 			Assert.That((m_dtree.Controls[2] as Slice).Label, Is.EqualTo("Citation Form"));
-			Assert.That("!?", Is.EqualTo((m_dtree.Controls[2] as Slice).Abbreviation));
+			Assert.That((m_dtree.Controls[2] as Slice).Abbreviation, Is.EqualTo("!?"));
 			Assert.That(abbr2 == (m_dtree.Controls[2] as Slice).Abbreviation, Is.False);
 		}