Cleanup lynx feature state subscriptions

[RaymondLuong3]

The subscription to the lynx state was being triggered every time the editor changed such as navigating to a new chapter. The result was that unnecessary subscriptions were being triggered and never unsubscribed. You can see this if you open the console in dev tools and try navigating between chapters. The warning "Max EventListeners exceeded" appears.

---

This change is 

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.90%. Comparing base (7ced458) to head (e9b44bd).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3900   +/-   ##
=======================================
  Coverage   80.90%   80.90%           
=======================================
  Files         630      630           
  Lines       40677    40677           
  Branches     6602     6595    -7     
=======================================
  Hits        32908    32908           
+ Misses       6742     6729   -13     
- Partials     1027     1040   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pmachapman]

@pmachapman reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on RaymondLuong3).

---

src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor.component.ts line 842 at r1 (raw file):

          this.setupTranslationEngine();
          this.projectDataChangesSub?.unsubscribe();
          this.projectDoc.remoteChanges$.subscribe(() => {

Just checking if this was a deliberate omission?

this.projectDataChangesSub = this.projectDoc.remoteChanges$.subscribe(() => {

Code quote:

          this.projectDoc.remoteChanges$.subscribe(() => {

[RaymondLuong3]

@RaymondLuong3 made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on pmachapman).

---

src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor.component.ts line 842 at r1 (raw file):

Previously, pmachapman (Peter Chapman) wrote…

Just checking if this was a deliberate omission?

this.projectDataChangesSub = this.projectDoc.remoteChanges$.subscribe(() => {

No that was not. Nice catch!

[pmachapman]

@pmachapman reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on RaymondLuong3).