Skip to content

update-mui-design-system #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 11, 2022
Merged

update-mui-design-system #11

merged 3 commits into from
Aug 11, 2022

Conversation

@ficast
Copy link
Contributor

@ficast ficast commented Aug 10, 2022 •
edited
Loading

image

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: b99153f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

anicioalexandre
anicioalexandre reviewed Aug 10, 2022
View reviewed changes
packages/design-system-mui/components/ButtonWithLoading/styled.tsx
export const Button = styled(MUIButton)(({ theme }) => ({})) as unknown as FC<ButtonProps>

export const CircularProgress = styled(MuiCircularProgress)(({ theme }) => ({
position: 'absolute',
Copy link
Collaborator

@anicioalexandre anicioalexandre Aug 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't be better if we show the loading state besides the children text? Not sure how the design looks like but seems better than overlapping the content

Copy link
Contributor Author

@ficast ficast Aug 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can always have your own loadingChildren to overwrite

packages/design-system-mui/package.json
"dependencies": {
"@emotion/react": "^11.10.0",
"@emotion/styled": "^11.10.0",
"@mui/icons-material": "^5.8.4",
Copy link
Collaborator

@anicioalexandre anicioalexandre Aug 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not add this until we need

Copy link
Contributor Author

@ficast ficast Aug 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using that

@anicioalexandre anicioalexandre merged commit 70e7da8 into BA-903-mui-design-system Aug 11, 2022
@anicioalexandre anicioalexandre deleted the BA-914-update-mui-design-system branch August 11, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anicioalexandre anicioalexandre anicioalexandre approved these changes

@nossila nossila Awaiting requested review from nossila

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ficast @anicioalexandre