From 8632800d78e6f04dc263ad63dfb4d3bbf4ea4a0a Mon Sep 17 00:00:00 2001 From: Philipp Schmitt Date: Wed, 2 Apr 2025 00:14:30 +0200 Subject: [PATCH 1/3] FEN-192 Do not hyperlink NavItems with children --- .../web/NavMini/NavSectionMini/NavList/NavItem/index.tsx | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/components/modules/navigations/web/NavMini/NavSectionMini/NavList/NavItem/index.tsx b/packages/components/modules/navigations/web/NavMini/NavSectionMini/NavList/NavItem/index.tsx index b0dfca66..babf6498 100644 --- a/packages/components/modules/navigations/web/NavMini/NavSectionMini/NavList/NavItem/index.tsx +++ b/packages/components/modules/navigations/web/NavMini/NavSectionMini/NavList/NavItem/index.tsx @@ -32,6 +32,7 @@ const NavItem = forwardRef( depth={depth} active={active} disabled={disabled} + disableRipple={hasChild} {...props} >
@@ -81,6 +82,8 @@ const NavItem = forwardRef( ) + if (hasChild) return content + return ( Date: Thu, 3 Apr 2025 22:19:52 +0200 Subject: [PATCH 2/3] FEN-192 line height for icons --- .../NavSectionVertical/Group/NavList/NavItem/index.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/components/modules/navigations/web/__shared__/NavSectionVertical/Group/NavList/NavItem/index.tsx b/packages/components/modules/navigations/web/__shared__/NavSectionVertical/Group/NavList/NavItem/index.tsx index 41b3e2d9..4c52099a 100644 --- a/packages/components/modules/navigations/web/__shared__/NavSectionVertical/Group/NavList/NavItem/index.tsx +++ b/packages/components/modules/navigations/web/__shared__/NavSectionVertical/Group/NavList/NavItem/index.tsx @@ -39,13 +39,13 @@ const NavItem = forwardRef( {...props} > {!subItem && icon && ( - + {icon} )} {subItem && icon ? ( - + {icon} ) : ( From b41bf17d1b846ffb44fa22bae888e0a3a38b50be Mon Sep 17 00:00:00 2001 From: Philipp Schmitt Date: Mon, 7 Apr 2025 19:00:36 +0200 Subject: [PATCH 3/3] FEN-192 --- packages/components/CHANGELOG.md | 6 ++++++ packages/components/package.json | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index 57d649b4..706abd9f 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -1,5 +1,11 @@ # @baseapp-frontend/components +## 1.0.32 + +### Patch Changes + +- Disables link for navigation elements with children and fixes vertical alignment + ## 1.0.31 ### Patch Changes diff --git a/packages/components/package.json b/packages/components/package.json index 5ff9342d..a79daa0d 100644 --- a/packages/components/package.json +++ b/packages/components/package.json @@ -1,7 +1,7 @@ { "name": "@baseapp-frontend/components", "description": "BaseApp components modules such as comments, notifications, messages, and more.", - "version": "1.0.31", + "version": "1.0.32", "sideEffects": false, "scripts": { "babel:transpile": "babel modules -d tmp-babel --extensions .ts,.tsx --ignore '**/__tests__/**','**/__storybook__/**'",