New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API 3.1 compatibility: Static configurable properties must be private and immutable. #16

Merged
merged 1 commit into from May 12, 2013

Conversation

Projects
None yet
2 participants
@tractorcow
Contributor

tractorcow commented Apr 1, 2013

@tractorcow

This comment has been minimized.

Show comment
Hide comment
@tractorcow

tractorcow May 6, 2013

Contributor

I just came here to make a pull request, and see that I've already made one. Any chance this could please be merged into main? The master is fixed to the 3.1 of core, but still has this outstanding compatibility issue.

Cheers mate!

Contributor

tractorcow commented May 6, 2013

I just came here to make a pull request, and see that I've already made one. Any chance this could please be merged into main? The master is fixed to the 3.1 of core, but still has this outstanding compatibility issue.

Cheers mate!

candidasa pushed a commit that referenced this pull request May 12, 2013

Julian Seidenberg
Merge pull request #16 from tractorcow/3.1-static-update
API 3.1 compatibility: Static configurable properties must be private and immutable.

@candidasa candidasa merged commit e833f22 into silverstripe-archive:master May 12, 2013

@tractorcow

This comment has been minimized.

Show comment
Hide comment
@tractorcow

tractorcow May 12, 2013

Contributor

Thank you!

Contributor

tractorcow commented May 12, 2013

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment