Skip to content
This repository

API 3.1 compatibility: Static configurable properties must be private and immutable. #37

Merged
merged 1 commit into from about 1 year ago

2 participants

Damian Mooyman Will Rossiter
Will Rossiter wilr merged commit eadc960 into from
Will Rossiter wilr closed this
Damian Mooyman

Thanks Will, nice quick response!

Damian Mooyman tractorcow deleted the branch
Will Rossiter
Owner
wilr commented

Well it was quick fix ha! Haven't pulled the latest 3.1 stuff into our apps yet so will be interesting to go through and fix up all the visibility identifiers..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Apr 02, 2013
Damian Mooyman API 3.1 compatibility: Static configurable properties must be private…
… and immutable.

Static configurable properties (db, allowed_actions, etc) are now private. See: http://doc.silverstripe.org/framework/en/3.1/changelogs/3.1.0#static-properties-are-immutable-and-private-you-must-use-config-api
1f7c2e7
This page is out of date. Refresh to see the latest.
2  code/controllers/GoogleSitemapController.php
@@ -17,7 +17,7 @@ class GoogleSitemapController extends Controller {
17 17
 	/**
18 18
 	 * @var array
19 19
 	 */
20  
-	public static $allowed_actions = array(
  20
+	private static $allowed_actions = array(
21 21
 		'index',
22 22
 		'sitemap'	
23 23
 	);
2  code/extensions/GoogleSitemapSiteTreeExtension.php
@@ -8,7 +8,7 @@ class GoogleSitemapSiteTreeExtension extends GoogleSitemapExtension {
8 8
 	/**
9 9
 	 * @var array
10 10
 	 */
11  
-	public static $db = array(
  11
+	private static $db = array(
12 12
 		"Priority" => "Varchar(5)"
13 13
 	);
14 14
 
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.