Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX re-enable TinyMCE anchor plugin #245

Merged

Conversation

NightJar
Copy link
Contributor

@NightJar NightJar commented Dec 6, 2019

The default profile in Silverstripe CMS 4 does not have the anchor
plugin enabled. It also seems that the copy-pasted config is not
actually 'inheriting' the default editor settings (as is the nature
of a re-definition), and thus the CWP editor config did not have the
anchor plugin enabled.

Perhaps the CWP config could be made to 'inherit' from the default
CMS config, via getOptions and setOptions, but this should be a
separate issue.

Resolves #244

The default profile in Silverstripe CMS 4 does not have the anchor
plugin enabled, and it also seems that the copy-pasted config is not
actually 'inheriting' the default editor settings, and thus the CWP
editor config did not have the anchor plugin enabled.
Copy link
Member

@Cheddam Cheddam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Cheddam Cheddam merged commit 577a791 into silverstripe:2.5 Dec 8, 2019
@Cheddam Cheddam deleted the pulls/2.5/anchor-editor-config branch December 8, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants