Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding script for cleaning up old data #713

Merged
merged 1 commit into from Oct 13, 2016
Merged

Adding script for cleaning up old data #713

merged 1 commit into from Oct 13, 2016

Conversation

halkyon
Copy link
Contributor

@halkyon halkyon commented Oct 11, 2016

No description provided.

@helpfulrobot
Copy link

@halkyon, thanks for your PR! By analyzing the blame information on this pull request, I identified @mateusz and @chillu to be potential reviewers

@stojg
Copy link

stojg commented Oct 11, 2016

Can I have a dry-run option that lists what will be deleted so I wouldn't be so scared to run this task?

@halkyon
Copy link
Contributor Author

halkyon commented Oct 11, 2016

@stojg yup, good idea

@halkyon
Copy link
Contributor Author

halkyon commented Oct 11, 2016

@stojg --dry-run arg added

$project = $environment->Project();
if (!$project || !$project->exists()) {
$log(sprintf(
'Environment (ID %s, Created: %s) is linked to a non-existent project. Deleting',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the name of the environment to the output please?
... is linked to a non-existent project 'Banana'

@stojg stojg merged commit 334660b into master Oct 13, 2016
@stojg stojg deleted the cleanup-script branch October 13, 2016 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants