Skip to content

Commit

Permalink
BUGFIX Using RandomGenerator class in PasswordEncryptor->salt()
Browse files Browse the repository at this point in the history
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114503 467b73ca-7a2a-4603-9d3b-597d59a354a9
  • Loading branch information
chillu committed Dec 5, 2010
1 parent 8b220b9 commit 1dddd52
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions security/PasswordEncryptor.php
Expand Up @@ -81,16 +81,17 @@ abstract function encrypt($password, $salt = null, $member = null);

/**
* Return a string value stored in the {@link Member->Salt} property.
* By default uses sha1() and mt_rand();
*
* Note: Only used when {@link Security::$useSalt} is TRUE.
*
* @uses RandomGenerator
*
* @param String $password Cleartext password
* @param Member $member (Optional)
* @return String Maximum of 50 characters
*/
function salt($password, $member = null) {
return substr(sha1(mt_rand()) . time(), 0, 50);
$generator = new RandomGenerator();
return substr($generator->generateHash('sha1'), 0, 50);
}

/**
Expand Down

0 comments on commit 1dddd52

Please sign in to comment.