GridFieldSortableHeader displays Filter after sorting

[manja]

GridField with SortableHeader component acts weird after sorting. On initial display everything is ok (as it should be), but after sorting content of the last column (always last one, no matter how many columns are there) header gets replaced with Filter icon. Spent over a day trying to fix it with @Zauberfisch on IRC.

Narrowed it down on GridFieldSortableHeader component, since when all other components are removed - bug still occurs.

Bug occurs on 3.0.5, 3.1 beta3 and latest build on May 4th, 2013. Tested on clean installs.

Initial display:

With two columns:

After sorting:

Two columns after sorting:

Code:
http://sspaste.com/paste/show/51852b75e9264

For two columns:
http://sspaste.com/paste/show/51852ceebf57f

[Zauberfisch]

I think I already have a lead on where this is coming from.

I haven't followed up on it, but filter header inserts itself into the last as it seems. and given that you have no actions column it overwrites the one that exists.
considering that, I am not sure if the bug is in SortableHeader, it might also be in FilterHeader.
the reason the bug only appears when SortableHeader is included, is that FilterHeader does not add a header by it self, but relays on SortableHeader to do it

[manja]

File: /framework/javascript/GridField.js
http://sspaste.com/paste/show/518532b6242ce

That fixed my problem - I simply wrapped functionality to replace content in last column if filter is hidden.

[chillu]

Care to submit a pull request? Presumably you've tested this across browsers?

[Zauberfisch]

Consider this issue assigned to me

[Zauberfisch]

Oh, it seems I have forgotten this issue.
@chillu could you please assign this to me. I will check if this is still valid and implement if required.

[chillu]

Hey Mr. Fisch, any progress on this?

[Zauberfisch]

its on the todo list :P

nah, in fact, I have scheduled some SilverStripe time this week.
currently working on userforms though, the framework issues will come later this week.

[wilr]

Anything in particular for userforms? 👍

[Zauberfisch]

I believe this is not the right tread to discuss userforms, but I am redoing the pull request that I did a year ago (dropdowns with title=>value).

[tractorcow]

Issue is caused by gridfield without actions column. Most components rely on this being a button column, not a data column.

Same problem, but different symptom to #3650

[kinglozzer]

Fixed in SS4. While a fix for 3.x might be accepted, I don’t see any value in leaving this issue open