Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.6.0 Regression / Font icons break with cache #1064

Closed
brynwhyman opened this issue Jun 30, 2020 · 1 comment · Fixed by silverstripe/webpack-config#47
Closed

4.6.0 Regression / Font icons break with cache #1064

brynwhyman opened this issue Jun 30, 2020 · 1 comment · Fixed by silverstripe/webpack-config#47
Assignees
@Cheddam
Labels
affects/v4 complexity/medium impact/high type/bug
Milestone
Sprint 64

Comments

@brynwhyman
Copy link

brynwhyman commented Jun 30, 2020 •
edited

Overview

New icons to be released in CMS 4.6.0 look to break if in a funny cache state on initial load
image

Assuming it's related to caching due to the workaround.

  • Left icon: form submission icon
  • Right icon: restricted file icon

To recreate

  1. Build a new project: silverstripe/recipe-cms: "4.6-dev" & silverstripe/userforms: "5.x-dev"
  2. Upload file to Files area
  3. Set visibility of new File to 'Logged-in users'
  4. See the broken icon

Workaround

Force-refresh the page

Versions

silverstripe/recipe-cms: "4.6-dev"
silverstripe/userforms: "5.x-dev"
@dnsl48 dnsl48 changed the title Font icons break with cache 4.6.0 Regression / Font icons break with cache Jul 5, 2020
@dnsl48 dnsl48 added this to the Sprint 64 milestone Jul 21, 2020
@emteknetnz emteknetnz mentioned this issue Jul 22, 2020
Merged
@emteknetnz
Copy link
Member

Fixed in silverstripe/webpack-config#47

@emteknetnz emteknetnz removed their assignment Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cheddam Cheddam

Labels
affects/v4 complexity/medium impact/high type/bug
Projects
None yet
Milestone
Sprint 64
Development

Successfully merging a pull request may close this issue.

FIX Add a querystring hash to fonts creative-commoners/webpack-config
4 participants
@Cheddam @emteknetnz @dnsl48 @brynwhyman