Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new step: I should see “some text value” in the “Table Name” table #24

Closed
wants to merge 1 commit into from

Conversation

madmatt
Copy link
Member

@madmatt madmatt commented Feb 4, 2014

The table name is generally specified by the <caption> element within the
<table> itself.

…ble.

The table name is generally specified by the <caption> element within the
<table> itself.
@madmatt
Copy link
Member Author

madmatt commented Feb 4, 2014

Arg, this appears to have pulled across another commit as well that should have been committed separately. It's also ready for merge, so this can be considered both. I'll squash it a bit later if that's easier to review.

@chillu
Copy link
Member

chillu commented Feb 9, 2014

Hmmm, this collides with @Then /^the "([^"]*)" table should contain "([^"]*)"$/ in CmsUiContext. I guess we could treat both grid fields and <table> as "tables" as far as the UI is concerned, right? In this case, could you consolidate the two methods and move them into BasicContext?

@chillu
Copy link
Member

chillu commented May 12, 2014

@jeffreyguo Good idea, although its a bit unclear what this test actually does. Is row order important? Can you leave out columns? And we need to stick to "should contain" for simple view assertions, "has the following data" means "insert data into a database table". But anyway, different scope to this PR.

@madmatt Can you please change the PR to extend the existing "table should contain" step?

@jeffreyguo
Copy link

@chillu Please ignore my comment above, the step definition is used for data input in a table, not for table data check. Sorry for my mistake.

@chillu
Copy link
Member

chillu commented Jun 4, 2014

@jeffreyguo @srizzling Can one of you please look through the comments and figure out the most appropriate course of action? Ideally as a new pull request.

@jeffreyguo
Copy link

@chillu @madmatt consolidated in new pull request #50

@chillu chillu closed this Jun 12, 2014
jeffreyguo pushed a commit to jeffreyguo/silverstripe-behat-extension that referenced this pull request Jan 12, 2016
ENH: allow specify database by filename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants