XML error when using RedirectPage in Blog #19

Closed
sminnee opened this Issue Mar 31, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@sminnee
Member

sminnee commented Mar 31, 2012

Hi!

I changed the page type of an old blog page to RedirectPage? for SEO reasons. This breaks the viewer with an XML_val error. We should exclude RedirectPages? from the Entries() function in BlogHolder?.php, but as I’m a noob in MySQL and on a hurry, I simply modified BlogHolder?.ss:

<% control BlogEntries %>
<% if ClassName = RedirectorPage %>
<% else %>
<% include BlogSummary %>
<% end_if %>
<% end_control %>
Hope it helps, Juan

@sminnee

This comment has been minimized.

Show comment
Hide comment
@sminnee

sminnee Mar 31, 2012

Member
@tractorcow

This comment has been minimized.

Show comment
Hide comment
@tractorcow

tractorcow Mar 5, 2014

Contributor

Seems ok in the current 2.4 branch. BlogTree::Entries method calls DataObject::get('BlogEntry', $filter, $order, '', $limit);, which shouldn't return any redirector pages. I've tested this and checked it myself.

Contributor

tractorcow commented Mar 5, 2014

Seems ok in the current 2.4 branch. BlogTree::Entries method calls DataObject::get('BlogEntry', $filter, $order, '', $limit);, which shouldn't return any redirector pages. I've tested this and checked it myself.

@tractorcow tractorcow closed this Mar 5, 2014

micmania1 added a commit that referenced this issue Feb 5, 2015

Merge pull request #19 from purplespider/modified-state
Display a 'Modified' tag in the State column for modified pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment