BlogManagementWidget incompatible with SS3 without Widgets module #43

Closed
drzax opened this Issue Aug 14, 2012 · 5 comments

4 participants

@drzax

The BlogManagementWidget class introduces an error in the SS3 admin area when attempting to view a site member record under Security.

This is due to use of Permission provider. The Permission class instantiates a singleton of every class which implements PermissionProvider And because the BlogManagementWidget inherits Widget (which doesn't exist) the whole thing falls over.

To reporoduce:

  1. Install SS3 and the Blog module (but no Widget module)
  2. Visit /admin/security/EditForm/field/Members/item/1/edit
@cam-findlay

I just found this same issue recently too... however once I do install the widget module I then have issues accessing the BlogTree and BlogHolder pages to edit content.

@unclecheese

Dependency "silverstripe/widgets" needs to be added to composer.json, no?

@drzax

I'm not so sure this is still a bug. There have been many changes to the blog module since this ticket was created. Also, if it is still a bug, I'd rather see the blog module not require the widgets module rather than just adding a requirement and calling it a day.

@tractorcow

The existing blog widgets could be split out into its own dependency and marked as a suggested library, alongside silverstripe/widgets. See suggest# at http://getcomposer.org/doc/04-schema.md.

It could be argued that it fragments the module somewhat, but not everyone will use or want widgets on their blog.

Unfortunately there's no easy way to include the classes in the core module that "activate" when the widgets module is installed. Is there?

@tractorcow

Fixed with ee53229

BLOGMANAGEMENT permission is now specified by the BlogHolder class, which doesn't depend on the Widgets module.

@tractorcow tractorcow closed this Mar 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment