Comma separated tags do not display properly without a space #59

Closed
digi-brains opened this Issue Oct 26, 2012 · 1 comment

Comments

Projects
None yet
2 participants
@digi-brains

Comma separated tags formatted like this (with spaces between the words):
Lorem, ipsum, dolor, etc...

Display like this in tags widget (properly, as separate words without commas):
Lorem ipsum dolor etc...

However, if you do not place a space between words, like this:
Lorem,ipsum,dolor,etc...

The entire tag entry is displayed with commas inline, like this (all as one word for each entry):
Lorem,ipsum,dolor,etc...

You should either enforce spaces after a comma (or) not assume people will put spaces between tags and clarify that in the documentation.

You can see the issue if you create a new blog entry and put commas between words, but don't put spaces between tags.

tractorcow added a commit to tractorcow/silverstripe-blog that referenced this issue Feb 28, 2014

BUG Fixed parsing of spaces and other whitespace in tag clouds. Fixes #…
…59

BUG Fixed incorrect encoding of SelectedAuthor and SelectedTag; Now correctly cast for templates using the `cast` config, not within filtering.
BUG Fixed TagCloudWidget.popularities config from being incorrectly accessed as a static property
BUG Fixed TagCloudWidget::getCMSFields triggering extend('updateCMSFields') twice
BUG Fixed TagCloudWidget::getTagsCollection discarding tag label capitalisation
BUG Fixed TagCloudWidget::getTagsCollection not correctly respecting minimum tag counts (as well as maximum tag counts) when determining the popularity CSS class to assign.
Test cases for TagCloudWidget
API BlogEntry::TagNames now safely extracts tags from a blog entry as an associative 'lowercase' => 'Entered Tag' format
PHPDoc fixes
Removed trailing '?>' tags from PHP files

tractorcow added a commit to tractorcow/silverstripe-blog that referenced this issue Feb 28, 2014

BUG Fixed parsing of spaces and other whitespace in tag clouds. Fixes #…
…59

BUG Fixed incorrect encoding of SelectedAuthor and SelectedTag; Now correctly cast for templates using the `cast` config, not within filtering.
BUG Fixed TagCloudWidget.popularities config from being incorrectly accessed as a static property
BUG Fixed TagCloudWidget::getCMSFields triggering extend('updateCMSFields') twice
BUG Fixed TagCloudWidget::getTagsCollection discarding tag label capitalisation
BUG Fixed TagCloudWidget::getTagsCollection not correctly respecting minimum tag counts (as well as maximum tag counts) when determining the popularity CSS class to assign.
Test cases for TagCloudWidget
API BlogEntry::TagNames now safely extracts tags from a blog entry as an associative 'lowercase' => 'Entered Tag' format
PHPDoc fixes
Removed trailing '?>' tags from PHP files
@tractorcow

This comment has been minimized.

Show comment Hide comment
@tractorcow

tractorcow Feb 28, 2014

Contributor

Finally addressed this bug... one year later. :) See my PR

Contributor

tractorcow commented Feb 28, 2014

Finally addressed this bug... one year later. :) See my PR

@wilr wilr closed this in #114 Mar 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment