Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Ss3 fixes #31
Conversation
halkyon
reviewed
Jul 3, 2012
| @@ -113,8 +113,8 @@ function getCMSFields() { | ||
| "INHERIT" => "Take value from parent Blog Tree" | ||
| ))); | ||
| - $fields->addFieldToTab("Root.Widgets", new CheckboxField("InheritSideBar", 'Inherit Sidebar From Parent')); | ||
| - $fields->addFieldToTab("Root.Widgets", new WidgetAreaEditor("SideBar")); | ||
| + //$fields->addFieldToTab("Root.Widgets", new CheckboxField("InheritSideBar", 'Inherit Sidebar From Parent')); |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
frankmullenger
Jul 3, 2012
Sorry, should not have been part of the commit. But the WidgetAreaEditor was throwing errors for me - does that class exist in SS3?
frankmullenger
Jul 3, 2012
Sorry, should not have been part of the commit. But the WidgetAreaEditor was throwing errors for me - does that class exist in SS3?
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
wilr
Jul 3, 2012
Owner
Widgets are now a separate module - In the mean time, a class_exists() for that would suffice in my view.
wilr
Jul 3, 2012
Owner
Widgets are now a separate module - In the mean time, a class_exists() for that would suffice in my view.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
frankmullenger
Jul 3, 2012
I've tidied this pull request up a little bit now. Let me know if any other changes are required.
frankmullenger
commented
Jul 3, 2012
|
I've tidied this pull request up a little bit now. Let me know if any other changes are required. |
added a commit
that referenced
this pull request
Jul 6, 2012
wilr
merged commit 6dd0e7d
into
silverstripe:ss3-fixes
Jul 6, 2012
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
Thanks! |
frankmullenger commentedJul 3, 2012
Blog pagination seems to require a PaginatedList in SS3.