Ss3 fixes #31

Merged
merged 2 commits into from Jul 6, 2012

Conversation

Projects
None yet
3 participants
@frankmullenger

Blog pagination seems to require a PaginatedList in SS3.

code/BlogTree.php
@@ -113,8 +113,8 @@ function getCMSFields() {
"INHERIT" => "Take value from parent Blog Tree"
)));
- $fields->addFieldToTab("Root.Widgets", new CheckboxField("InheritSideBar", 'Inherit Sidebar From Parent'));
- $fields->addFieldToTab("Root.Widgets", new WidgetAreaEditor("SideBar"));
+ //$fields->addFieldToTab("Root.Widgets", new CheckboxField("InheritSideBar", 'Inherit Sidebar From Parent'));

This comment has been minimized.

Show comment Hide comment
@halkyon

halkyon Jul 3, 2012

Owner

Howcome these lines are commented out?

@halkyon

halkyon Jul 3, 2012

Owner

Howcome these lines are commented out?

This comment has been minimized.

Show comment Hide comment
@frankmullenger

frankmullenger Jul 3, 2012

Sorry, should not have been part of the commit. But the WidgetAreaEditor was throwing errors for me - does that class exist in SS3?

@frankmullenger

frankmullenger Jul 3, 2012

Sorry, should not have been part of the commit. But the WidgetAreaEditor was throwing errors for me - does that class exist in SS3?

This comment has been minimized.

Show comment Hide comment
@wilr

wilr Jul 3, 2012

Owner

Widgets are now a separate module - In the mean time, a class_exists() for that would suffice in my view.

@wilr

wilr Jul 3, 2012

Owner

Widgets are now a separate module - In the mean time, a class_exists() for that would suffice in my view.

@frankmullenger

This comment has been minimized.

Show comment Hide comment
@frankmullenger

frankmullenger Jul 3, 2012

I've tidied this pull request up a little bit now. Let me know if any other changes are required.

I've tidied this pull request up a little bit now. Let me know if any other changes are required.

wilr added a commit that referenced this pull request Jul 6, 2012

@wilr wilr merged commit 6dd0e7d into silverstripe:ss3-fixes Jul 6, 2012

@wilr

This comment has been minimized.

Show comment Hide comment
@wilr

wilr Jul 6, 2012

Owner

Thanks!

Owner

wilr commented Jul 6, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment