Update templates/Includes/BlogSummary.ss #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch is less confusing and now renders the tags correctly
MINOR whitespace in PHP cleanup
…r. If it's not set, then fall back to using "mysite blog" or whatever the global $project variable is set to
Refactored BlogEntries() to be more testable. Added tests for Entries().
…ed $extensions variable
…stance of it, since it's a 3rd party class
…Collector functionality. The table is now sorted alphabetically by namespace and entity. Entities now include more translatable statics from DataObject subclasses like $db, $has_one etc.
…rated by a DataObjectDecorator
$this->extend('updateCMSFields', $fields);
is already called by;
$fields = parent::getCMSFields();
Replaced the old page icons, and moved where the blog specific fields appear in the CMS to above the content area
Updated template elements for 3.0. Made html follow proper heading hierarchy Optimized generated html so it can be more easily styled.
Fix archive widget so that dates render correctly
Merge pull request #41 from mattclegg/master
FIXED: Missing hook to extensions updateCMSFields function
ENHANCEMENT: UI Improvements and template updates
Added composer.json file which will help this module for submission on proposed extension.silverstripe.org website. For more information please visit this page http://extension.openbees.org/instructions/
For SilverStripe 3+, descriptions can be shown for each available page type when pages are created. This commit adds descriptions for the BlogEntry, BlogHolder and BlogTree classes, as derived from comments within the code.
NEW Add composer.json
Add descriptions for blog page types (Fixes #42)
Contains some minor bugs : 1 - JSON doesn't allow multi line string so making "description" field in single line. 2 - Few typo errors .
Bug : Removed errors from Composer.json
Added required dependency.
Update README.md
Is there a need to wrap $Content.FirstParagraph(html) in its own <p> tag since it's using html and tinymce will put <p> tags in the content?
|
What happens when users are using bbcode (I'm not sure any actually are), does it still wrap it? |
|
I haven't checked as I've never used bbcode, but I will do as soon as I can and get back to you. |
|
Currently extra p tags are being created before and after $Content.FirstParagraph(html). Not sure about bbcode either but think its better to clean up the template for the majority and dev's can add the back if needed. what say yee? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a need to wrap $Content.FirstParagraph(html) in its own p tag since it's using html and tinymce will put p tags in the content?