Internationalized all messages #6

Closed
wants to merge 248 commits into
from

Conversation

Projects
None yet
@weberhofer
  • added german translations
  • to make dates internationalized, too, the
    setlocale(LC_TIME, Translatable::get_current_locale() . ".UTF8");
    should be set in the mysite/code/Page.php ContentController's init
    function

ajoneil and others added some commits Sep 6, 2007

Added ConfirmNewsletterSignup_member.ss as an example how to customis…
…e, added themedCSS requirements to controller

Carlos Barberis and others added some commits May 28, 2010

Carlos Barberis
Reverted form to post entry to BlogHolder
ENHANCEMENT: added post as an allowed method on BlogTree
ENHANCEMENT: create a template function, BlogEntry::Content(), for co…
…nsistency of template writing and enable using text summary functionalities in template
ENHANCEMENT: Allow notifying multiple trackback urls per blog entry
APICHANGE: TrackBackDecorator::trackbackNotify() allow one parameter
APICHANGE: remove TrackBackDecorator::ShouldTrackbackNotify()
Carlos Barberis
BUGFIX: Got rid of link to post new entry in the front end on a BlogT…
…ree (method does not exist on BlogTree).

Thanks smurkas (#4692)
MINOR Added BlogEntry_Controller->PageComments() as a temporary worka…
…round to avoid deprecation warnings from new 'comments' module
phalkun
MINOR: Move documentation from http://doc.silverstripe.org
MINOR: Update README to Markdown format
BUGFIX: support for legacy installations for the date based blog entr…
…y listing using slashes rather than dashes. PATCH via jcinteractive. (#5)
* Internationalized all messages
* added german translations
* to make dates internationalized, too, the
  setlocale(LC_TIME, Translatable::get_current_locale() . ".UTF8");
  should be set in the mysite/code/Page.php ContentController's init
  function
@cbarberis

This comment has been minimized.

Show comment
Hide comment
@cbarberis

cbarberis May 26, 2011

Member

Hi there,

what happens if you don't set setlocale in Page_Controller::init()?

cheers
Carlos

Member

cbarberis commented May 26, 2011

Hi there,

what happens if you don't set setlocale in Page_Controller::init()?

cheers
Carlos

@weberhofer

This comment has been minimized.

Show comment
Hide comment
@weberhofer

weberhofer May 27, 2011

Hi Carlos,

when you don't set it, all dates are displayed in the US-format (Eg. "May 2011" instead of "Mai 2011" in German).

Best regards,
Johannes

PS: We have an additional cosmetic patch to add (it's a "| |" which should be a "|" only).

Index: webroot/blog/templates/Includes/BlogSummary.ss

--- webroot/blog/templates/Includes/BlogSummary.ss (revision 8396)
+++ webroot/blog/templates/Includes/BlogSummary.ss (working copy)
@@ -1,6 +1,6 @@

$MenuTitle

-

<% _t('POSTEDBY', 'Posted by') %> $Author.XML <% _t('POSTEDON', 'on') %> $Date.FormatI18N(%x) | | $Comments.Count <% _t('COMMENTS', 'Comments') %>

-

<% _t('POSTEDBY', 'Posted by') %> $Author.XML <% _t('POSTEDON', 'on') %> $Date.FormatI18N(%x) | $Comments.Count <% _t('COMMENTS', 'Comments') %>

<% if TagsCollection %>

Tags:

Am 27.05.11 01:44, schrieb cbarberis:

Hi there,

what happens if you don't set setlocale in Page_Controller::init()?

cheers
Carlos

Johannes Weberhofer
Weberhofer GmbH, Austria, Vienna

Hi Carlos,

when you don't set it, all dates are displayed in the US-format (Eg. "May 2011" instead of "Mai 2011" in German).

Best regards,
Johannes

PS: We have an additional cosmetic patch to add (it's a "| |" which should be a "|" only).

Index: webroot/blog/templates/Includes/BlogSummary.ss

--- webroot/blog/templates/Includes/BlogSummary.ss (revision 8396)
+++ webroot/blog/templates/Includes/BlogSummary.ss (working copy)
@@ -1,6 +1,6 @@

$MenuTitle

-

<% _t('POSTEDBY', 'Posted by') %> $Author.XML <% _t('POSTEDON', 'on') %> $Date.FormatI18N(%x) | | $Comments.Count <% _t('COMMENTS', 'Comments') %>

-

<% _t('POSTEDBY', 'Posted by') %> $Author.XML <% _t('POSTEDON', 'on') %> $Date.FormatI18N(%x) | $Comments.Count <% _t('COMMENTS', 'Comments') %>

<% if TagsCollection %>

Tags:

Am 27.05.11 01:44, schrieb cbarberis:

Hi there,

what happens if you don't set setlocale in Page_Controller::init()?

cheers
Carlos

Johannes Weberhofer
Weberhofer GmbH, Austria, Vienna

@weberhofer

This comment has been minimized.

Show comment
Hide comment
@weberhofer

weberhofer Jun 22, 2011

I have now changed the code as suggested by chillu; looks good.

I have now changed the code as suggested by chillu; looks good.

@camfindlay

This comment has been minimized.

Show comment
Hide comment
@camfindlay

camfindlay Jan 24, 2014

Contributor

@chillu can you peer review when you have amoment to see whether this from 2 years ago is still relevant?

Contributor

camfindlay commented Jan 24, 2014

@chillu can you peer review when you have amoment to see whether this from 2 years ago is still relevant?

@tractorcow

This comment has been minimized.

Show comment
Hide comment
@tractorcow

tractorcow Feb 21, 2014

The Widget module now has its own hooks for translating CMS visible fields, so it's not necessary to implement these in the PHP.

There are missing translation keys however. E.g. ArchiveWidget.TITLE, ArchiveWidget.CMSTITLE, ArchiveWidget.DESCRIPTION that need to be loaded into transifex. I'm not sure how one would go around requesting additional values to add to the index. :)

The Widget module now has its own hooks for translating CMS visible fields, so it's not necessary to implement these in the PHP.

There are missing translation keys however. E.g. ArchiveWidget.TITLE, ArchiveWidget.CMSTITLE, ArchiveWidget.DESCRIPTION that need to be loaded into transifex. I'm not sure how one would go around requesting additional values to add to the index. :)

@camfindlay

This comment has been minimized.

Show comment
Hide comment
@camfindlay

camfindlay May 10, 2014

Contributor

bump @tractorcow any idea what we should do with this PR? Time to close or can we pick anything from this useful?

Contributor

camfindlay commented May 10, 2014

bump @tractorcow any idea what we should do with this PR? Time to close or can we pick anything from this useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment