Permalink
Browse files

BUG Restrict URLSegment preview to editable fields

This fixes a bug where the Translatable module
would have a duplicate preview because it had
another ".urlsegment" field showing the value in its
original language.

See silverstripe/silverstripe-translatable#43
  • Loading branch information...
1 parent f5007a5 commit 2923e55c712530241ba79bdbca1ca793ae003588 @chillu chillu committed Aug 16, 2012
Showing with 7 additions and 3 deletions.
  1. +7 −3 javascript/SiteTreeURLSegmentField.js
@@ -11,9 +11,13 @@
* Constructor: onmatch
*/
onmatch : function() {
- this._addActions(); // add elements and actions for editing
- this.edit(); // toggle
- this._autoInputWidth(); // set width of input field
+ // Only initialize the field if it contains an editable field.
+ // This ensures we don't get bogus previews on readonly fields.
+ if(this.find(':text').length) {
+ this._addActions(); // add elements and actions for editing
+ this.edit(); // toggle
+ this._autoInputWidth(); // set width of input field
+ }
this._super();
},

0 comments on commit 2923e55

Please sign in to comment.