Skip to content
This repository
Browse code

BUG Incorrect html nesting of breadcrumbs

Removed h2 from outside breadcrumbs, and put it within the breadcrumbs
div

Relies on sapphire commit 72b4fbf
  • Loading branch information...
commit 4fab9b8248819dc9008d5b94b5437cd833de31ac 1 parent 4c73f23
Naomi Guyer authored November 12, 2012 mateusz committed November 22, 2012
4  templates/Includes/AssetAdmin_Content.ss
@@ -5,11 +5,11 @@
5 5
 		<div class="cms-content-header-info">
6 6
 			<% include BackLink_Button %>
7 7
 
8  
-			<h2 id="page-title-heading">
  8
+			
9 9
 			<% with Controller %>
10 10
 				<% include CMSBreadcrumbs %>
11 11
 			<% end_with %>
12  
-			</h2>
  12
+			
13 13
 		</div>
14 14
 		<% if Fields.hasTabset %>
15 15
 			<% with Fields.fieldByName('Root') %>
6  templates/Includes/CMSMain_Content.ss
... ...
@@ -1,10 +1,8 @@
1 1
 <div id="pages-controller-cms-content" class="cms-content center cms-tabset $BaseCSSClasses" data-layout-type="border" data-pjax-fragment="Content" data-ignore-tab-state="true">
2 2
 
3 3
 	<div class="cms-content-header north">
4  
-		<div class="cms-content-header-info">
5  
-			<h2>
6  
-				<% include CMSBreadcrumbs %>
7  
-			</h2>
  4
+		<div class="cms-content-header-info">			
  5
+			<% include CMSBreadcrumbs %>			
8 6
 		</div>
9 7
 	
10 8
 		<div class="cms-content-header-tabs">
6  templates/Includes/CMSPagesController_Content.ss
... ...
@@ -1,10 +1,8 @@
1 1
 <div id="pages-controller-cms-content" class="cms-content center cms-tabset $BaseCSSClasses" data-layout-type="border" data-pjax-fragment="Content">
2 2
 
3 3
 	<div class="cms-content-header north">
4  
-		<div class="cms-content-header-info">
5  
-			<h2>
6  
-				<% include CMSBreadcrumbs %>
7  
-			</h2>
  4
+		<div class="cms-content-header-info">			
  5
+			<% include CMSBreadcrumbs %>			
8 6
 		</div>
9 7
 	
10 8
 		<div class="cms-content-header-tabs">
6  templates/Includes/CMSSettingsController_Content.ss
@@ -2,12 +2,10 @@
2 2
 
3 3
 	<div class="cms-content-header north">
4 4
 		<% with EditForm %>
5  
-			<div class="cms-content-header-info">
6  
-				<h2>
  5
+			<div class="cms-content-header-info">				
7 6
 				<% with Controller %>
8 7
 					<% include CMSBreadcrumbs %>
9  
-				<% end_with %>
10  
-				</h2>
  8
+				<% end_with %>				
11 9
 			</div>
12 10
 			<% if Fields.hasTabset %>
13 11
 				<% with Fields.fieldByName('Root') %>
6  templates/Includes/ReportAdmin_Content.ss
@@ -3,12 +3,10 @@
3 3
 	<div class="cms-content-header north">
4 4
 		<% with EditForm %>
5 5
 			<div class="cms-content-header-info">
6  
-				<% include BackLink_Button %>
7  
-				<h2 id="page-title-heading">
  6
+				<% include BackLink_Button %>				
8 7
 				<% with Controller %>
9 8
 					<% include CMSBreadcrumbs %>
10  
-				<% end_with %>
11  
-				</h2>
  9
+				<% end_with %>				
12 10
 			</div>
13 11
 		<% end_with %>
14 12
 	</div>

0 notes on commit 4fab9b8

Please sign in to comment.
Something went wrong with that request. Please try again.