Localized page name in "add page" dialog and dropdowns (see #7798)

silverstripe · Aug 26, 2012 · 59546cc · 59546cc
1 parent 6b6dfae
commit 59546cc
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/code/controllers/CMSMain.php b/code/controllers/CMSMain.php
@@ -468,8 +468,8 @@ public function PageTypes() {
 
 			$addAction = $instance->i18n_singular_name();
 
-			// Get description
-			$description = _t($class . '.DESCRIPTION');
+			// Get description (convert 'Page' to 'SiteTree' for correct localization lookups)
+			$description = _t((($class == 'Page') ? 'SiteTree' : $class) . '.DESCRIPTION');
 
 			if(!$description) {
 				$description = $instance->uninherited('description');
@@ -484,7 +484,8 @@ public function PageTypes() {
 				'AddAction' => $addAction,
 				'Description' => $description,
 				// TODO Sprite support
-				'IconURL' => $instance->stat('icon')
+				'IconURL' => $instance->stat('icon'),
+				'Title' => singleton($class)->i18n_singular_name(),
 			)));
 		}
 

diff --git a/code/controllers/CMSPageAddController.php b/code/controllers/CMSPageAddController.php
@@ -21,7 +21,7 @@ function AddForm() {
 		$pageTypes = array();
 		foreach($this->PageTypes() as $type) {
 			$html = sprintf('<span class="page-icon class-%s"></span><strong class="title">%s</strong><span class="description">%s</span>',
-				$type->getField('ClassName'),
+				$type->getField('Title'),
 				$type->getField('AddAction'),
 				$type->getField('Description')
 			);

diff --git a/code/model/SiteTree.php b/code/model/SiteTree.php
@@ -2699,7 +2699,9 @@ function providePermissions() {
 	 * @return String
 	 */
 	function i18n_singular_name() {
-		return _t($this->class.'.SINGULARNAME', $this->singular_name());
+		// Convert 'Page' to 'SiteTree' for correct localization lookups
+		$class = ($this->class == 'Page') ? 'SiteTree' : $this->class;
+		return _t($class.'.SINGULARNAME', $this->singular_name());
 	}
 
 	/**