Permalink
Browse files

BUGFIX: fixing an edge-case bug where a 404-page would get statically…

… published and overwrite the homepage of the site (this would sometimes happen when a RedirectorPage was set to an external URL and still referenced an internal page ID)
  • Loading branch information...
1 parent 4abe136 commit 838ac9717719083d3718d804fe6c8c16355ef331 Julian Seidenberg committed Jul 9, 2012
Showing with 4 additions and 3 deletions.
  1. +4 −3 code/staticpublisher/FilesystemPublisher.php
@@ -186,11 +186,12 @@ function publishPages($urls) {
$response = Director::test(str_replace('+', ' ', $url));
Requirements::clear();
-
-
-
+
singleton('DataObject')->flushCache();
+ //skip any responses with a 404 status code. We don't want to turn those into statically cached pages
+ if (!$response || $response->getStatusCode() == '404') continue;
+
// Generate file content
// PHP file caching will generate a simple script from a template
if($this->fileExtension == 'php') {

0 comments on commit 838ac97

Please sign in to comment.