Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

BUGFIX Don't filter AssetAdmin list view when showing detail view (fi…

…xes #7408)
  • Loading branch information...
commit 8b8de0564ccbc0698ab6bf012d9947722e08eaa4 1 parent 63467b0
@chillu chillu authored
Showing with 7 additions and 0 deletions.
  1. +7 −0 code/controllers/AssetAdmin.php
View
7 code/controllers/AssetAdmin.php
@@ -91,6 +91,13 @@ public function getList() {
$params = $this->request->requestVar('q');
$list = $context->getResults($params);
+ // Don't filter list when a detail view is requested,
+ // to avoid edge cases where the filtered list wouldn't contain the requested
+ // record due to faulty session state (current folder not always encoded in URL, see #7408).
+ if($this->request->param('ID') == 'field') {
+ return $list;
+ }
+
// Re-add previously removed "Name" filter as combined filter
// TODO Replace with composite SearchFilter once that API exists
if(isset($params['Name'])) {

2 comments on commit 8b8de05

@ajoneil

This breaks pagination in AssetAdmin - the gridfield will lose the context of which folder it is in and show files from all folders.

@chillu
Owner

@ajoneil Wanna file a new bug for it?

Please sign in to comment.
Something went wrong with that request. Please try again.