Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG Missing FilterHeader in SiteTree listview #810

Closed
wants to merge 1 commit into from
Closed

BUG Missing FilterHeader in SiteTree listview #810

wants to merge 1 commit into from

Conversation

ARNHOE
Copy link

@ARNHOE ARNHOE commented Jul 27, 2013

@ARNHOE
Copy link
Author

ARNHOE commented Jul 27, 2013

There is still a major flaw in this though. I can't get the filter away from LastEdited.

@ARNHOE
Copy link
Author

ARNHOE commented Aug 15, 2013

@chillu Any news on this pull request? Anything that needs to be improved or?

@chillu
Copy link
Member

chillu commented Aug 15, 2013

That's how it looks for me at the moment with this patch applied: http://db.tt/MTFVzb6Y

So we'll need the following:

  • Show the filter by default, not only after sorting by lastedited
  • Distribute the filter correctly between cells
  • Allow filtering by name (so using a different column to filter than to display, since that contains HTML)

Given we're already tracking this in a bug, and this probably needs some deeper GridField work, i'll close this PR for the time being. Thanks for pushing to make the CMS UI better, anyway :)

@phptek
Copy link
Contributor

phptek commented Mar 17, 2014

See also #947.

@chillu note that the odd position of the arrow icon CSS background is due to the unusual implementation of this "child display" logic within a gridfield that GF may not have originally catered for.

Modifying GridField.css and adding min-width:12px; to thead tr.filter-header .fieldgroup "fixes" that, but of course leaves the issue you note that the magnifying icon should show by default.

@phptek
Copy link
Contributor

phptek commented Mar 17, 2014

Removed.

phptek pushed a commit to phptek/silverstripe-framework that referenced this pull request Mar 25, 2014
- Ensures magnifying icon only shows when required.
- Related to: silverstripe/silverstripe-cms#810 (@chillu comment).
- Also fixes silverstripe#1492.
- Includes Behat tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants