Skip to content

3.1.x SiteConfig EditForm not refreshed after save #895

Closed
pine3ree opened this Issue Nov 14, 2013 · 3 comments

1 participant

@pine3ree

CMSSettingsController:
I see a
POST admin/settings/EditForm 200 OK
and the CurrentForm fragment upated in the response, but the changes are not applied to the page like it happens with CMSMain cotroller classes.

@pine3ree

i guess the reason could be the name of the fragment "CurrentForm" itself. Shouldn't it be "Content" for CMSSettingsController?

@pine3ree

The request sent to CMSSettingsController::save_siteconfig shows fragments CurrentForm,Breadcrumbs. The Content fragment callback is never called when saving site config.

Adding back in line 46

$form->setAttribute('data-pjax-fragment', 'CurrentForm');

and

$neg->setCallback('Content', function() use(&$controller) {

at line 29

seems to resolve the problem

@pine3ree

Another solution is to add back "CurrentForm" data-pjax-fragment="Content {HERE}" in CMSSettingsController_Content.ss (as it was in SS 3.0), but previous solution leaves the Settings editor on the current tab after updating the form.

Using previous solution getResponseNegotiator could also be removed in CMSSettingsController as the Content fragment callback is the same as LeftAndMain default.

@chillu chillu added a commit that closed this issue Dec 2, 2013
@chillu chillu Reload "Settings" form on save (fixes #895)
Regression from 920da0d
bd5f631
@chillu chillu closed this in bd5f631 Dec 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.