ENHANCEMENT Change Breadcrumbs to return an ArrayList instead of HTML #930

Closed
micmania1 opened this Issue Feb 6, 2014 · 7 comments

Comments

Projects
None yet
4 participants
Member

micmania1 commented Feb 6, 2014

Anybody got any objections to me doing this?

To maintain backward compatibility we could extend ArrayList and provide a forTemplate which renders the old HTML.

@micmania1 micmania1 referenced this issue in silverstripe/silverstripe-framework Feb 6, 2014

Closed

ENHANCEMENT Change Breadcrumbs to return an ArrayList instead of HTML #2824

Owner

wilr commented Feb 6, 2014

Previously it has been discussed to move the array list / page generated to something like getBreadcrumbItems and keep Breadcrumbs as the rendered view.

Member

micmania1 commented Feb 7, 2014

Sounds good to me. I'll get on it when I get a chance.

@chillu chillu added the enhancement label Feb 9, 2014

Owner

chillu commented Feb 9, 2014

+1 :)

Member

micmania1 commented Feb 9, 2014

Just making this change and noticed that the $unlinked param isn't included. See here: http://api.silverstripe.org/3.1/source-class-SiteTree.html#674-705

How would you prefer I made this change? Remove the $unlinked param or leave it in to avoid breaks?

Also, which branch should this be raised against? This may depend on the $unlinked param I suppose.

Owner

wilr commented Feb 10, 2014

I would say unlinked parameter could be implemented to work again (easier than deprecating it). You shouldn't need unlinked on the getBreadcrumbItems but $unlinked should push through to the template and the link tags wrapped in an <% if not Unlinked %>.

Not sure what the idea was about having breadcrumbs that didn't link but might as well keep.

Owner

wilr commented Feb 10, 2014

@micmania1 and this would be suitable for 3.1 as long as the API is not changed.

@simonwelsh simonwelsh added the master label Mar 16, 2014

Member

micmania1 commented Mar 23, 2014

PR: #974

@micmania1 micmania1 closed this Oct 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment