'Pages' Admin ListView Gridfield sort search disappears on click #947

Closed
LukePercy opened this Issue Feb 18, 2014 · 4 comments

Comments

Projects
None yet
4 participants

search functionality

When sorting the 'Pages' sitetree gridfield a search icon appears, but clicking this results in it disappearing.

You can also no longer sort last updated or page type once you click this.

Reproduction Steps:

  1. Visit admin/pages/#cms-content-listview
  2. Click on 'Last Updated' to sort this field
  3. Observe Magnify icon for Search appears on column heading
  4. Click on Magnify icon

Actual:
Magnify icon disappears and you are no longer able to search

Expected:
Search function appears and works as expected on all columns.
Sorting functionality works as expected upon selecting Search criteria.

simonwelsh added the 3.1 label Mar 16, 2014

Contributor

phptek commented Mar 17, 2014

See also:

Issue also exists in:

  • taxonomy admin
  • workflows admin
Contributor

phptek commented Mar 17, 2014

Looks like something within GridField changes in terms of how table-headers are built when you add a GridFieldComponent (e.g. new GridFieldEditButton()) "fixes" it (although leaves you with an edit action you didn't want...)

Contributor

phptek commented Mar 17, 2014

Set the GridField up as follows in CMSMain#ListViewForm() and the overall behaviour is as expected save for the odd first-column visual issue with the arrow icons. The latter issue is due to a missing CSS min-width (See comment in #810)

new GridFieldToolbarHeader(),
new GridFieldSortableHeader(),
new GridFieldFilterHeader(),
new GridFieldDataColumns(),
new GridFieldEditButton(),
new GridFieldPaginator(15)

@phptek phptek pushed a commit to phptek/silverstripe-framework that referenced this issue Mar 25, 2014

Russell Michell FIX Fixes silverstripe/silverstripe-cms#947 GridField sorting.
- Ensures magnifying icon only shows when required.
- Related to: silverstripe/silverstripe-cms#810 (@chillu comment).
- Also fixes #1492.
- Includes Behat tests.
408ba37
Owner

chillu commented May 18, 2017

No longer the case in 4.x

chillu closed this May 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment