BUG Fix encoding of SearchForm::getSearchQuery #1013

Merged
merged 1 commit into from Jun 14, 2014

3 participants

@tractorcow

This made it awkward for user code to extract the query value for use in other applications; This would otherwise have to be xml decoded again.
Casting has been promoted to the templating level via DBField::create_field and a SearchForm.casting config setting.

Rebase of #1005 against master
[ref: CWPBUG-153]

@mateusz
SilverStripe Ltd. member

How about also adding a note to the upgrade notes? Otherwise I think this is good to merge after Travis passes.

@tractorcow tractorcow BUG Fix encoding of SearchForm::getSearchQuery
This made it awkward for user code to extract the query value for use in other applications; This would otherwise have to be xml decoded again.
Casting has been promoted to the templating level via DBField::create_field and a `SearchForm.casting` config setting.
5dd0583
@tractorcow

It would be good if there was an attached /docs/en/changelogs file for CMS. I'll add it in the meantime to framework. ;)

@tractorcow

Test cases pass @mateusz , since I merged up from 3.1

@tractorcow tractorcow added a commit to tractorcow/silverstripe-framework that referenced this pull request May 5, 2014
@tractorcow tractorcow Changelog note for silverstripe/silverstripe-cms#1013 380e6c1
@tractorcow tractorcow referenced this pull request in silverstripe/silverstripe-framework May 5, 2014
Merged

Changelog note for CMS:#1013 #3105

@tractorcow

Here's the requisite upgrading note: silverstripe/silverstripe-framework#3105

@tractorcow tractorcow added this to the 3.2 alpha 1 milestone May 7, 2014
@tractorcow tractorcow added the master label May 7, 2014
@stojg

Looks good to me, I've merged the change log in framework.

@stojg stojg merged commit 30d42e0 into silverstripe:master Jun 14, 2014
@tractorcow tractorcow deleted the tractorcow:pulls/3.2-fix-fulltext-query-encoding branch Jun 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment