Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Pulls/redirector proto relative #1022

Merged
merged 1 commit into from Jun 13, 2014

Conversation

Projects
None yet
2 participants
Owner

chillu commented May 29, 2014

Allows for consistent redirection via http:// or https://. Use case is an external site which "shares" the login state by including an iframe from the SilverStripe site as a header. Since I've set Session.cookie_secure=true, the http:// and https:// versions don't share a cookie, so we have to ensure the correct protocol is retained.

Contributor

tractorcow commented May 29, 2014

Test failure is probably due to change in master behaviour from silverstripe/silverstripe-framework@5f7ebd3. I'll fix the behat tests for CMS.

tractorcow added a commit that referenced this pull request Jun 13, 2014

Merge pull request #1022 from silverstripe-iterators/pulls/redirector…
…-proto-relative

Pulls/redirector proto relative

@tractorcow tractorcow merged commit 1a85c7a into silverstripe:master Jun 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment