Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Pulls/3.2/fix upload behat #1034

Merged
merged 1 commit into from Jun 17, 2014

Conversation

Projects
None yet
2 participants
Contributor

tractorcow commented Jun 17, 2014

Due to the change in behaviour from silverstripe/silverstripe-framework@5f7ebd3 in 3.2, we now respect the value of the Upload.replaceFile config, rather than forcing it to true if we notify of replacement. Now we instead only show the notification if this config would trigger an overwrite.

The new default behaviour is to rename the file, as it used to be prior to the addition of the overwrite notification.

@chillu chillu added a commit that referenced this pull request Jun 17, 2014

@chillu chillu Merge pull request #1034 from tractorcow/pulls/3.2/fix-upload-behat
Pulls/3.2/fix upload behat
c45fb5a

@chillu chillu merged commit c45fb5a into silverstripe:master Jun 17, 2014

@tractorcow tractorcow deleted the tractorcow:pulls/3.2/fix-upload-behat branch Jun 17, 2014

Contributor

tractorcow commented Jun 17, 2014

We can just about remove the 'allowed failures' for php 5.6 too. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment