Skip to content

ENHANCEMENT: If silverstripe_version is empty, attempts to retrieve it from composer.lock file #289

Closed
wants to merge 4 commits into from

2 participants

@purplespider

Is there an issue with this request? Or should I have submitted it to the 3.1 branch? Sorry if something isn't quite right with my contribution etiquette!

@chillu
SilverStripe Ltd. member
chillu commented Feb 28, 2013

It was close :) I've moved it to framework instead, otherwise it won't work in admin/assets etc.
Also made the logic a bit more flexible in terms of module configuration (not duplicating everything for cms and framework). See silverstripe/silverstripe-framework@2b6d735 and 0f8d7a0

@chillu chillu closed this Feb 28, 2013
@purplespider

Thanks Ingo, that makes a lot of sense! How does this update find it's way into 3.1?

@chillu
SilverStripe Ltd. member
chillu commented Mar 1, 2013

We're merging 3.0 into 3.1 frequently

@srizzling srizzling pushed a commit to srizzling/silverstripe-behat-extension that referenced this pull request Nov 15, 2013
@chillu chillu Removed CMSMain->CMSVersion(), using LeftAndMain instead
Implementation got more complex (see silverstripe/silverstripe-cms#289),
including composer.lock file support. So trying to to duplicate too much.
0f8d7a0
@tractorcow tractorcow pushed a commit to tractorcow/silverstripe-framework that referenced this pull request Mar 31, 2014
@chillu chillu Using composer.lock for LeftAndMain->CMSVersion() 2b6d735
@sminnee sminnee pushed a commit to sminnee/silverstripe-admin that referenced this pull request May 13, 2016
@chillu chillu Using composer.lock for LeftAndMain->CMSVersion() c3c6f58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.