Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

2.4 fix for Translatable and batch actions #55

Closed
wants to merge 2 commits into from

4 participants

@smares

Fix for batch actions not working on translated pages - courtesy of http://www.balbuss.com/translatable-batch-actions-hack/

@wilr
Collaborator

@chillu / @sminnee this would more suit post - 2.4 branch? Are we sticking with 2.4.* for security only related work?

@chillu
Owner

Yeah, non-critical bugfixes go to master and post-2.4, security fixes in addition to that onto 2.4. This is not critical from whata I can tell.

@simonwelsh simonwelsh closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
View
2  javascript/CMSMain_left.js
@@ -458,7 +458,7 @@ batchActionGlobals = {
});
// Post to the server to ask which pages can have this batch action applied
- var applicablePagesURL = $('choose_batch_action').value + '/applicablepages?csvIDs=' + ids.join(',');
+ var applicablePagesURL = $('choose_batch_action').value + '/applicablepages?csvIDs=' + ids.join(',') + "&locale=" + $('batchactions_options_locale').value;
jQuery.getJSON(applicablePagesURL, function(applicableIDs) {
var i;
var applicableIDMap = {};
View
1  templates/Includes/CMSMain_left.ss
@@ -73,6 +73,7 @@
<input type="hidden" name="csvIDs" />
<input type="hidden" name="SecurityID" value="$SecurityID" />
+ <input type="hidden" name="locale" id='batchactions_options_locale' value="$Locale" />
<div id="actionParams"></div>
<div>
<select id="choose_batch_action">
Something went wrong with that request. Please try again.