Skip to content

FIX linktracking not working on file shortcode links #954

Closed
wants to merge 1 commit into from

3 participants

@sheadawson

File links were only being tracked on img tags and a tags that had normal file paths for the href value, not shortcodes.

So files linked via the HTMLEditor -> insert link -> download a file -> select file, would display "Used on: 0 page(s)" when viewing them in the cms.

@simonwelsh

Tests?

@simonwelsh simonwelsh added the 3.1 label Mar 16, 2014
@spark-green

Can you cancel or update this pull request? The REGEX needs to pick up a couple of short code variants: [file_link id=...] and [file_link,id=...]. I can add a separate pull request to capture this change.

@sheadawson

Hey guys, I'm not going to have the time to write tests for this for a while sorry, I'm really busy and also not too familiar with the whole testing thing yet. I feel it's an important fix though as currently users may be deleting files they have been lead to believe are unused. I'll close for now if you want to continue with a separate pull request @SparkGreen

@sheadawson sheadawson closed this Mar 26, 2014
@spark-green

Replaced with issue #983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.