BUG Report admin don't listen to filters #956

Merged
merged 1 commit into from Mar 12, 2014

Projects

None yet

5 participants

@stojg
Contributor
stojg commented Feb 25, 2014

It seems like filter params that are added to the url are added in a bad way

Currently

?0[name]=filters[ContentReviewOwnerID]&0[value]=1

Expected:

?filters[ContentReviewOwnerID]=1
@stojg @stojg stojg BUG Report admin don't listen to filters
It seems like filter params that are added to the url are added in a bad way

Currently

    ?0[name]=filters[ContentReviewOwnerID]&0[value]=1

Expected:

    ?filters[ContentReviewOwnerID]=1
1625d12
@stojg
Contributor
stojg commented Feb 25, 2014

@chillu Do you think this has something to do with silverstripe/silverstripe-framework@4103190 ?

I'm not sure when this broke atm.

@stevie-mayhew
Contributor

Is this a priority to be merged? It's blocking me from upgrading at the moment.

@wilr wilr merged commit dca9c7c into silverstripe:3.1 Mar 12, 2014
@ss23
Contributor
ss23 commented Mar 12, 2014

FYI Reports in now a module in 3.2 so probably needs a PR to that module as well wink

@stevie-mayhew stevie-mayhew added a commit to stevie-mayhew/silverstripe-cms that referenced this pull request Mar 12, 2014
@stevie-mayhew stevie-mayhew BUGFIX: pass the correct param values through to reports (see silvers… f1024db
@stevie-mayhew stevie-mayhew referenced this pull request in silverstripe/silverstripe-reports Mar 12, 2014
Merged

BUGFIX: pass the correct param values through to reports #5

@stojg stojg deleted the stojg:reportadmin-bug branch Mar 13, 2014
@camspiers

Thanks for fixing this @stojg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment