Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

FEATURE: Apply design to forums #36

Closed
wants to merge 1 commit into from

5 participants

@adrexia

Generic theming for forums. Designed to pick up as much from the base theme as possible, whilst still providing enough structural styling to make the forums usable out of the box. Has been tested in Dew, Simple, and SSexpress themes.

This is a major change in some ways, as previously the design component of forums has been very minimal. However, without design the forums module is one of the most confusing and inaccessible so I do think it needs to be done. The changes within the templates themselves are mostly around turning multiple tables, and divs styled like tables, into one table, and moving a few of the elements from the header to the footer.

code/Forum.php
@@ -1242,6 +1242,8 @@ function doAdminFormFeatures($data, $form) {
$thread->write();
}
}
+
+ Session::set('ForumAdminMsg',_t('Forum.SETTINGSUPDATED','Thread Settings Have Been Updated'));
@halkyon Owner
halkyon added a note

Umm, it's kinda minor, but shouldn't that be "Thread settings have been updated"?

@adrexia
adrexia added a note

Sure. I just found it in the old code and put it back. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@adrexia adrexia FEATURE: Apply design to forums
Generic theming for forums. Designed to pick up as much from the base
theme as possible, whilst still providing enough structural styling to
make the forums usable out of the box. Has been tested in Dew, Simple,
and SSExpress themes.

This is a major change in some ways, as previously the design component
of forums has been very minimal. However, without design the forums
module is one of the most confusing and inaccessible so I do think it
needs to be done. The changes within the templates themselves are
mostly around turning multiple tables, and divs styled like tables,
into one table, and moving a few of the elements from the header to the
footer.
276bc2f
@clarkepaul

I'll see if I can get some motion on this one

@adrexia

This seems a little dead in the water.

@chillu chillu added the enhancement label
@camfindlay
Owner

I recently started the blog subtheme for simple theme going again. Seems there is a stub project to make the forum subtheme composer controlled too but no actual markup or styles yet. https://github.com/silverstripe-themes/silverstripe-simple-forum

@clarkepaul

It does, good timing though as we have a road map planning session for our ss product and extras... Will add it to the list.

@adrexia

This wasn't simple, but a wire-frame theme. Paul did the original design years ago. I found that without the styles it was difficult to even know how the forum was supposed to behave.

@camfindlay
Owner

@adrexia any change you can rebase and commit, keen to start clearing these forum PR's out :) Doesn't seem to want to allow an auto merge on this PR.

@camfindlay
Owner

Going to close this particular PR and look to reintroduce a new one based on a rebased branch. Will be needing some frontend fix ups I think. Seeing as this is now 2+ years old...

@camfindlay camfindlay closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 15, 2012
  1. @adrexia

    FEATURE: Apply design to forums

    adrexia authored
    Generic theming for forums. Designed to pick up as much from the base
    theme as possible, whilst still providing enough structural styling to
    make the forums usable out of the box. Has been tested in Dew, Simple,
    and SSExpress themes.
    
    This is a major change in some ways, as previously the design component
    of forums has been very minimal. However, without design the forums
    module is one of the most confusing and inaccessible so I do think it
    needs to be done. The changes within the templates themselves are
    mostly around turning multiple tables, and divs styled like tables,
    into one table, and moving a few of the elements from the header to the
    footer.
Something went wrong with that request. Please try again.