Skip to content
This repository
Browse code

BUGFIX The SilverStripe installer throwing warning on settings that w…

…as legit.
  • Loading branch information...
commit 1a81c3de2712a21c014593c7b23b703b7328159b 1 parent 06dd79f
Stig Lindqvist authored March 28, 2012

Showing 1 changed file with 3 additions and 4 deletions. Show diff stats Hide diff stats

  1. 7  dev/install/install.php5
7  dev/install/install.php5
@@ -402,9 +402,9 @@ class InstallRequirements {
402 402
 			$this->requireDateTimezone(array('PHP Configuration', 'date.timezone set and valid', 'date.timezone option in php.ini must be set in PHP 5.3.0+', ini_get('date.timezone')));
403 403
 		}
404 404
 
405  
-		$this->suggestPHPSetting('asp_tags', array(''), array('PHP Configuration', 'asp_tags option turned off', 'This should be turned off as it can cause issues with SilverStripe'));
406  
-		$this->suggestPHPSetting('magic_quotes_gpc', array(''), array('PHP Configuration', 'magic_quotes_gpc option turned off', 'This should be turned off, as it can cause issues with cookies. More specifically, unserializing data stored in cookies.'));
407  
-		$this->suggestPHPSetting('display_errors', array(''), array('PHP Configuration', 'display_errors option turned off', 'Unless you\'re in a development environment, this should be turned off, as it can expose sensitive data to website users.'));
  405
+		$this->suggestPHPSetting('asp_tags', array(false,0,''), array('PHP Configuration', 'asp_tags option turned off', 'This should be turned off as it can cause issues with SilverStripe'));
  406
+		$this->suggestPHPSetting('magic_quotes_gpc', array(false,0,''), array('PHP Configuration', 'magic_quotes_gpc option turned off', 'This should be turned off, as it can cause issues with cookies. More specifically, unserializing data stored in cookies.'));
  407
+		$this->suggestPHPSetting('display_errors', array(false,0,''), array('PHP Configuration', 'display_errors option turned off', 'Unless you\'re in a development environment, this should be turned off, as it can expose sensitive data to website users.'));
408 408
 
409 409
 		// Check memory allocation
410 410
 		$this->requireMemory(32*1024*1024, 64*1024*1024, array("PHP Configuration", "Memory allocated (PHP config option 'memory_limit')", "SilverStripe needs a minimum of 32M allocated to PHP, but recommends 64M.", ini_get("memory_limit")));
@@ -414,7 +414,6 @@ class InstallRequirements {
414 414
 
415 415
 	function suggestPHPSetting($settingName, $settingValues, $testDetails) {
416 416
 		$this->testing($testDetails);
417  
-
418 417
 		$val = ini_get($settingName);
419 418
 		if(!in_array($val, $settingValues) && $val != $settingValues) {
420 419
 			$testDetails[2] = "$settingName is set to '$val' in php.ini.  $testDetails[2]";

0 notes on commit 1a81c3d

Please sign in to comment.
Something went wrong with that request. Please try again.