Permalink
Browse files

BUG Remove extraneous </div> breaking IE8 image embedding (os#8218)

Editor was not able to add images to TinyMCE - both newly uploaded and
old ones from the local assets.
  • Loading branch information...
mateusz committed Jan 30, 2013
1 parent 3457f43 commit 3111ad12fac6a59138e17a884abe49010c295df5
Showing with 1 addition and 1 deletion.
  1. +1 −1 templates/Includes/HtmlEditorField_viewfile.ss
@@ -26,7 +26,7 @@
<div class="ss-uploadfield-item-cancel cancel">
<button data-icon="deleteLight" class="ss-uploadfield-item-cancel ss-uploadfield-item-remove" title="<% _t('UploadField.REMOVE', 'Remove') %>">
<% _t('UploadField.REMOVE', 'Remove') %>
- </button></div>
+ </button>
<div class="ss-uploadfield-item-edit edit">
<button class="ss-uploadfield-item-edit ss-ui-button ui-corner-all" title="<% _t('UploadField.EDITINFO', 'Edit this file') %>" data-icon="pencil">

1 comment on commit 3111ad1

@chillu

This comment has been minimized.

Show comment Hide comment
@chillu

chillu Jul 9, 2013

Member

Hey @mateusz, thanks for fixing that. I just spent 1h+ trying to track this down in 3.0 until I've found this commit in 3.1, backported it now. Just a reminder that we need to put more effort in backporting critical bugfixes as they arise. No blame - I'm the worst at this - just an FYI :)

Member

chillu commented on 3111ad1 Jul 9, 2013

Hey @mateusz, thanks for fixing that. I just spent 1h+ trying to track this down in 3.0 until I've found this commit in 3.1, backported it now. Just a reminder that we need to put more effort in backporting critical bugfixes as they arise. No blame - I'm the worst at this - just an FYI :)

Please sign in to comment.