Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Merge pull request #171 from silverstripe-scienceninjas/pull/fix-defa…

…ult-sorting-bugs-subtract

BUGFIX Subtract should not add order by on subselect
  • Loading branch information...
commit 3f682531e66792ff093a8f33af4f29a6c27463fb 2 parents eef6450 + 056e564
@stojg stojg authored
Showing with 0 additions and 1 deletion.
  1. +0 −1  model/DataQuery.php
View
1  model/DataQuery.php
@@ -514,7 +514,6 @@ function applyRelation($relation) {
public function subtract(DataQuery $subtractQuery, $field='ID') {
$subSelect= $subtractQuery->getFinalisedQuery();
$subSelect->select($this->expressionForField($field, $subSelect));
- $this->ensureSelectContainsOrderbyColumns($subSelect);
$this->where($this->expressionForField($field, $this).' NOT IN ('.$subSelect->sql().')');
}
Please sign in to comment.
Something went wrong with that request. Please try again.