From 8f2ede8fcfc80441e655b4103dc4b4badd6cdfb8 Mon Sep 17 00:00:00 2001 From: Ingo Schommer Date: Wed, 16 May 2012 13:17:19 +0200 Subject: [PATCH] MINOR Fixed syntax errors from SQLQuery/DataQuery cleanup --- model/DataQuery.php | 8 ++++---- model/SQLQuery.php | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/model/DataQuery.php b/model/DataQuery.php index 6e0b4d0a27b..986bd60cb18 100644 --- a/model/DataQuery.php +++ b/model/DataQuery.php @@ -325,7 +325,7 @@ function count() { * @param String $field Unquoted database column name (will be escaped automatically) */ function Max($field) { - return $this->getFinalisedQuery()->aggregate(sprintf('MAX("%s")', Convert::raw2sql($field))->execute()->value(); + return $this->getFinalisedQuery()->aggregate(sprintf('MAX("%s")', Convert::raw2sql($field)))->execute()->value(); } /** @@ -334,7 +334,7 @@ function Max($field) { * @param String $field Unquoted database column name (will be escaped automatically) */ function Min($field) { - return $this->getFinalisedQuery()->aggregate(sprintf('MIN("%s")', Convert::raw2sql($field))->execute()->value(); + return $this->getFinalisedQuery()->aggregate(sprintf('MIN("%s")', Convert::raw2sql($field)))->execute()->value(); } /** @@ -343,7 +343,7 @@ function Min($field) { * @param String $field Unquoted database column name (will be escaped automatically) */ function Avg($field) { - return $this->getFinalisedQuery()->aggregate(sprintf('AVG("%s")', Convert::raw2sql($field))->execute()->value(); + return $this->getFinalisedQuery()->aggregate(sprintf('AVG("%s")', Convert::raw2sql($field)))->execute()->value(); } /** @@ -352,7 +352,7 @@ function Avg($field) { * @param String $field Unquoted database column name (will be escaped automatically) */ function Sum($field) { - return $this->getFinalisedQuery()->aggregate((sprintf('SUM("%s")', Convert::raw2sql($field)))->execute()->value(); + return $this->getFinalisedQuery()->aggregate(sprintf('SUM("%s")', Convert::raw2sql($field)))->execute()->value(); } /** diff --git a/model/SQLQuery.php b/model/SQLQuery.php index 7a5d867177b..3808fecbd2a 100644 --- a/model/SQLQuery.php +++ b/model/SQLQuery.php @@ -848,7 +848,7 @@ function sql() { else $filter = "(" . implode(") AND (", $join['filter']) . ")"; $aliasClause = ($alias != $join['table']) ? " AS \"" . Convert::raw2sql($alias) . "\"" : ""; - $this->from[$alias] = strtoupper($join['type']) . " JOIN \"{" . Convert::raw2sql($join['table']) . "}\"$aliasClause ON $filter"; + $this->from[$alias] = strtoupper($join['type']) . " JOIN \"" . Convert::raw2sql($join['table']) . "\"$aliasClause ON $filter"; } }